Enable dual stack #1376
Enable dual stack #1376
Conversation
Subnets are one of the resources that control the ability to use a dual stack (IPV4 and IPV6). These are required to be set on resource creation, and they cannot be altered post creation. The user has the option to set the stack type for each subnet (IPV4_ONLY, IPV4_IPV6, or IPV6_ONLY). The default will be IPV4_ONLY.
…me value as the StackType in the SubnetSpecs.
k8s-ci-robot
added
release-note
k8s-ci-robot
added
cncf-cla: yes
|
Hi @barbacbd. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/M
✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
There was a problem hiding this comment.
Thanks for this PR @barbacbd
It looks reasonable to me
/lgtm
Let's see how it behaves in testing.
Also
/assign @cpanato @richardcase
k8s-ci-robot
added
the
lgtm
|
/test ? |
|
@damdo: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-cluster-api-provider-gcp-e2e-workload-upgrade |
|
@barbacbd: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
the workload upgrade was failing before, we need to fix that :) |
|
yep lets merge and follow up /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: barbacbd, cpanato The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Could we include this patch to latest minor or major release, this is an important fix for clusters dual stack feature? |
|
/cherrypick release-1.8 |
|
@salasberryfin: new pull request created: #1394 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind api-change
/kind feature
What this PR does / why we need it:
Adding the ability to enable dual stacks.
Subnets are one of the resources that control the ability to use a dual stack (IPV4
and IPV6). These are required to be set on resource creation, and they cannot be
altered post creation.
The user has the option to set the stack type for each subnet (IPV4_ONLY, IPV4_IPV6, or
IPV6_ONLY). The default will be IPV4_ONLY.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes # https://issues.redhat.com/browse/CORS-3762
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: