-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Kubernetes 1.29+ #1333
Support Kubernetes 1.29+ #1333
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks @mloiseleur. /lgtm |
/assign @richardcase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, mloiseleur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.8 |
@cpanato: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@cpanato: new pull request created: #1346 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Related to #1331
Special notes for your reviewer:
Since we did not manage to get cloud-provider external works properly and it's not (yet) removed, I open this PR to (at least) provide a working Out Of the Box user XP when trying to start a Kubernetes 1.29+ cluster with this provider.
I'm not sure that documentation is needed, since it's already documented upstream.
TODOs:
Release note: