-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For internal Load Balancer use the same API port as external LB #1282
Conversation
Hi @bfournie. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/assign @damdo /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bfournie, cpanato The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@bfournie - this looks good. Would you be able to rebase so that we could get this in? |
bb65d81
to
5d4d048
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@richardcase this is rebased now, did you want to LGTM?
/lgtm |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Sets the API port used for the Internal Load Balancer to be the same as that used for the External Load Balancer.
Which issue(s) this PR fixes
Fixes #1273
TODOs:
Release note: