Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete load balancers before subnets #1252

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Delete load balancers before subnets #1252

merged 1 commit into from
Jun 4, 2024

Conversation

bfournie
Copy link
Contributor

@bfournie bfournie commented Jun 3, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:
When using an internal load balancer, the internal IP addresses uses a cluster subnet. To avoid "already being used" errors on the subnet deletion, delete the load balancer first.

This is a follow-on from #1222.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

None

@bfournie
Delete load balancers before subnets
48558ad 
When using an internal load balancer, the internal IP addresses
uses a cluster subnet. To avoid "already being used" errors on
the subnet deletion, delete the load balancer first.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Jun 3, 2024
@k8s-ci-robot k8s-ci-robot requested review from cpanato and damdo June 3, 2024 21:24
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 3, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @bfournie. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 3, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 3, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name Link
🔨 Latest commit 48558ad
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/665e3470cd97a60008975d8e
😎 Deploy Preview https://deploy-preview-1252--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bfournie
Copy link
Contributor Author

bfournie commented Jun 3, 2024

/cc @damdo @cpanato

@bfournie bfournie mentioned this pull request Jun 3, 2024
Merged
3 tasks
cpanato
cpanato reviewed Jun 4, 2024
View reviewed changes
controllers/gcpcluster_controller.go
loadbalancers.New(clusterScope),
subnets.New(clusterScope),
firewalls.New(clusterScope),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we delete the firewalls before as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's necessary as there are no conflicting resources being used by the firewalls.

@cpanato
Copy link
Member

cpanato commented Jun 4, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 4, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie, cpanato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4cb3460 into kubernetes-sigs:main Jun 4, 2024
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.1.0 milestone Jun 4, 2024
@bfournie bfournie deleted the subnet-delete-order branch June 4, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@damdo damdo Awaiting requested review from damdo

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bfournie @k8s-ci-robot @cpanato