Skip deletion of Subnet when created ouside CAPG.

[jwmay2012]

What type of PR is this?

/kind feature

What this PR does / why we need it:

When a cluster is deployed to an existing subnet, it's because the creator wanted the subnet to persist beyond when the cluster gets deleted. This PR takes the existing "skip delete" logic from networks and applies it to subnets, allowing clusters that were created in existing subnets with existing VMs, to pass all finalizer checks and successfully delete.

Which issue(s) this PR fixes:
Fixes #1231

Special notes for your reviewer:

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

Subnets created outside of CAPG are no longer deleted when the cluster is deleted, similar to networks. A subnet is considered created outside of CAPG when it's description does not match the description specified in the GCPCluster Spec, or does not match the default value by CAPG.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: jwmay2012 / name: Jordan May (b57f2d8)

[k8s-ci-robot]

Welcome @jwmay2012!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-gcp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-gcp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @jwmay2012. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name	Link
🔨 Latest commit	b57f2d8
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/6650aaa6c936840008b77a3f
😎 Deploy Preview	https://deploy-preview-1233--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[cpanato]

/ok-to-test

[cpanato]

/lgtm

/hold for @richardcase or @damdo

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, jwmay2012

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cpanato]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[salasberryfin]

Just added a couple of nit-picking comments that I think can improve readability and help align the code with other parts of the provider.

[damdo]

Mostly LGTM, left some logging nitpicks.

[jwmay2012]

All suggestions look good and integrated. Thanks!

[damdo]

Thanks!
/lgtm

[damdo]

/unhold