-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GKE update version check #1098
Fix GKE update version check #1098
Conversation
Hi @kahun. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Thanks for this @kahun 🙇 With a fix like this its helpful to add a release note instead of using NONE because this will then get highlighted when we do a release. I have updated the release note for this PR. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kahun, richardcase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you for the feedback; I will keep it in mind for future PRs :P |
What type of PR is this?
/kind bug
What this PR does / why we need it:
The GKE update process enters an infinite loop during the reconcile process because it compares desiredMasterVersion to InitialClusterVersion instead of CurrentMasterVersion.
TODOs:
Release note: