-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making GCPManagedCluster.Network a required field #1285
Comments
/assign |
potentially could be added as part of v1beta2 #1287 |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/kind bug
What steps did you take and what happened:
As noted in this issue #1187 here, the
Network
field is a required field implicitly, as during the reconcile process of GCPManagedCluster, requires the presence of this field.What we could potentially do here based on this discussion #1259 (comment) is to make it a required field either in
v1beta1
orv1beta2
What did you expect to happen:
GCPManagedCluster.Network
becomes a required field.Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
reference PR which fixes the controller crashing. #1259
Environment:
kubectl version
):/etc/os-release
):The text was updated successfully, but these errors were encountered: