Update to CAPI v1.4

[hrak]

Issue #, if available:

#249

Description of changes:

This PR updates the cluster-api dependency to v1.4.6.

Testing performed:

make test
tested using tilt against a Cloudstack 4.18 cluster

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!

Name	Link
🔨 Latest commit	55ac08a
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-cloudstack/deploys/65bd229da3637e000844dc62
😎 Deploy Preview	https://deploy-preview-309--kubernetes-sigs-cluster-api-cloudstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[k8s-ci-robot]

Hi @hrak. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hrak]

OK, I think this is ready for testing now. I successfully tested using kind/Tilt against a Cloudstack 4.18 cluster.

[vishesh92]

/ok-to-test

[hrak]

Yeah i was afraid that part was going to fail already. Upgrade instructions for capi v1.2 to v1.3 mention that

e2e tests are upgraded to use Ginkgo v2 (v2.5.0) and Gomega v1.22.1. Providers who use the test framework from this release will also need to upgrade, because Ginkgo v2 can’t be imported alongside v1.

I will be on holiday for the next 2 weeks though, so I'm afraid i cant address this atm.

[hrak]

Can someone trigger the e2e tests on this?

[vishesh92]

/run-e2e -c 4.18

[blueorangutan]

@vishesh92 a jenkins job has been kicked to run test with following paramaters:

• kubernetes version: 1.27.2
• CloudStack version: 4.18
• hypervisor: kvm
• template: ubuntu-2004-kube
• Kubernetes upgrade from: 1.26.5 to 1.27.2

[hrak]

I just noticed CAPI 1.4.7 is out so i will update to that once the e2e tests finish + address the go.mod replace comment above.

[hrak]

It appears @blueorangutan is very busy :) tests not working anymore?

[rohityadavcloud]

@hrak it could be that the job failed at the backend CI/CD pipeline, or BO ran out of Github API rate limits - in which cases we may not hear anything from BO. The best thing to do in such cases is to try again or get one of @vishesh92 @weizhouapache to assist.

/run-e2e -c 4.18

[blueorangutan]

@rohityadavcloud a jenkins job has been kicked to run test with following paramaters:

• kubernetes version: 1.27.2
• CloudStack version: 4.18
• hypervisor: kvm
• template: ubuntu-2004-kube
• Kubernetes upgrade from: 1.26.5 to 1.27.2

[hrak]

Ran the tests locally and found an issue in the invalid resource e2e test. Will update the PR shortly.

[blueorangutan]

@g-gaston a jenkins job has been kicked to run test with following paramaters:

• kubernetes version: 1.27.2
• CloudStack version: 4.18
• hypervisor: kvm
• template: ubuntu-2004-kube
• Kubernetes upgrade from: 1.26.5 to 1.27.2

[rohityadavcloud]

/ok-to-test

[rohityadavcloud]

/run-e2e -c 4.18

[blueorangutan]

@rohityadavcloud a jenkins job has been kicked to run test with following paramaters:

• kubernetes version: 1.27.2
• CloudStack version: 4.18
• hypervisor: kvm
• template: ubuntu-2004-kube
• Kubernetes upgrade from: 1.26.5 to 1.27.2

[g-gaston]

/run-e2e -c 4.18

[blueorangutan]

@g-gaston a jenkins job has been kicked to run test with following paramaters:

• kubernetes version: 1.27.2
• CloudStack version: 4.18
• hypervisor: kvm
• template: ubuntu-2004-kube
• Kubernetes upgrade from: 1.26.5 to 1.27.2

[pokearu]

/run-e2e -c 4.18

[g-gaston]

/run-e2e -c 4.18

[blueorangutan]

@g-gaston a jenkins job has been kicked to run test with following paramaters:

• kubernetes version: 1.27.2
• CloudStack version: 4.18
• hypervisor: kvm
• template: ubuntu-2004-kube
• Kubernetes upgrade from: 1.26.5 to 1.27.2

[blueorangutan]

Setting up environment failed

[rohityadavcloud]

@pokearu to avoid ddos of the CI env, only owners can kick the e2e tests with the command:

/run-e2e -c 4.18

[rohityadavcloud]

/run-e2e -c 4.18

[blueorangutan]

@rohityadavcloud a jenkins job has been kicked to run test with following paramaters:

• kubernetes version: 1.27.2
• CloudStack version: 4.18
• hypervisor: kvm
• template: ubuntu-2004-kube
• Kubernetes upgrade from: 1.26.5 to 1.27.2

[blueorangutan]

@rohityadavcloud a jenkins job has been kicked to run test with following paramaters:

• kubernetes version: 1.27.2
• CloudStack version: 4.18
• hypervisor: kvm
• template: ubuntu-2004-kube
• Kubernetes upgrade from: 1.26.5 to 1.27.2

[blueorangutan]

Setting up environment failed

[blueorangutan]

Setting up environment failed

[g-gaston]

@pokearu tested this by running all e2e manually and all tests are passing (thx 👏🏻 )

I propose to merge this even if can't get the bot to run the tests, IMO the manual run is enough

Lazy consensus for tomorrow?

cc @hrak @rohityadavcloud

[hrak]

Yes please 🙏 Currently on holiday but very much looking forward to get this merged. I have CAPI 1.5 support ready to submit as a follow up. Op do 1 feb. 2024 20:01 schreef Guillermo Gaston ***@***.***>:

…

@pokearu <https://github.com/pokearu> tested this by running all e2e manually and all tests are passing (thx 👏🏻 ) I propose to merge this even if can't get the bot to run the tests, IMO the manual run is enough Lazy consensus for tomorrow? cc @hrak <https://github.com/hrak> @rohityadavcloud <https://github.com/rohityadavcloud> — Reply to this email directly, view it on GitHub <#309 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAO7KEYK6YXYJVFDTIWIAVLYRQNDBAVCNFSM6AAAAAA4HTJ4KKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRSGQ2DEMZYGU> . You are receiving this because you were mentioned.Message ID: <kubernetes-sigs/cluster-api-provider-cloudstack/pull/309/c1922442385@ github.com>

[g-gaston]

/lgtm
/approve

thanks @hrak!
great work here and sorry it took so long!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: g-gaston, hrak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [g-gaston]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[g-gaston]

@hrak you mentioned you have 1.5 branch
any chance it's pushed somewhere? i can help rebasing and to start getting it pushed through the e2e tests

[weizhouapache]

/run-e2e -c 4.18

[blueorangutan]

@weizhouapache a jenkins job has been kicked to run test with following paramaters:

• kubernetes version: 1.27.2
• CloudStack version: 4.18
• hypervisor: kvm
• template: ubuntu-2004-kube
• Kubernetes upgrade from: 1.26.5 to 1.27.2

[weizhouapache]

@weizhouapache a jenkins job has been kicked to run test with following paramaters:

• kubernetes version: 1.27.2
• CloudStack version: 4.18
• hypervisor: kvm
• template: ubuntu-2004-kube
• Kubernetes upgrade from: 1.26.5 to 1.27.2

results

Summarizing 3 Failures:
 [FAIL] When testing app deployment to the workload cluster with slow network [ToxiProxy] [BeforeEach] Should be able to download an HTML from the app deployed to the workload cluster
 /jenkins/workspace/capc-e2e-new/test/e2e/toxiproxy/toxiProxy.go:203
 [FAIL] When testing app deployment to the workload cluster with network interruption [ToxiProxy] [BeforeEach] Should be able to create a cluster despite a network interruption during that process
 /jenkins/workspace/capc-e2e-new/test/e2e/toxiproxy/toxiProxy.go:203
 [FAIL] When testing affinity group [It] Should have host affinity group when affinity is pro
 /jenkins/workspace/capc-e2e-new/test/e2e/common.go:332

Ran 28 of 29 Specs in 9285.818 seconds
FAIL! -- 25 Passed | 3 Failed | 0 Pending | 1 Skipped
--- FAIL: TestE2E (9285.82s)
FAIL