Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Make machine providerID consistent with node #655

Merged
merged 1 commit into from
May 29, 2020
Merged

✨Make machine providerID consistent with node #655

merged 1 commit into from
May 29, 2020

Conversation

alexander-demicev
Copy link
Contributor

@alexander-demicev alexander-demicev commented May 28, 2020 •
edited
Loading

This PR makes machine providerID consistent with node providerID and fixes the similar issue that was in CAPA - kubernetes-sigs/cluster-api-provider-aws#1693

https://github.com/kubernetes/kubernetes/blob/323f34858de18b862d43c40b2cced65ad8e24052/staging/src/k8s.io/legacy-cloud-providers/azure/azure_vmss.go#L289

Release note:

✨ Make machine providerID consistent with node providerID

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label May 28, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @alexander-demichev!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-azure 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-azure has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @alexander-demichev. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 28, 2020
@k8s-ci-robot k8s-ci-robot added the area/provider/azure Issues or PRs related to azure provider label May 28, 2020
@k8s-ci-robot k8s-ci-robot requested a review from nader-ziada May 28, 2020 12:30
@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label May 28, 2020
@nader-ziada
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 28, 2020
@nader-ziada
Copy link
Contributor

@alexander-demichev can you please add a release note section to the PR description

@alexander-demicev alexander-demicev changed the title Make machine providerID consistent with node ✨Make machine providerID consistent with node May 28, 2020
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 28, 2020
@devigned
Copy link
Contributor

I think the release note has extra "`"'s.

@alexander-demicev
Copy link
Contributor Author

@devigned Fixed, thanks

@k8s-ci-robot
Copy link
Contributor

@devigned: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

  • /test pull-cluster-api-provider-azure-test
  • /test pull-cluster-api-provider-azure-build
  • /test pull-cluster-api-provider-azure-integration
  • /test pull-cluster-api-provider-azure-e2e
  • /test pull-cluster-api-provider-azure-verify
  • /test pull-cluster-api-provider-azure-conformance-v1alpha3-master
  • /test pull-cluster-api-provider-azure-conformance-v1alpha3-1-18
  • /test pull-cluster-api-provider-azure-apidiff

Use /test all to run the following jobs:

  • pull-cluster-api-provider-azure-test
  • pull-cluster-api-provider-azure-build
  • pull-cluster-api-provider-azure-integration
  • pull-cluster-api-provider-azure-e2e
  • pull-cluster-api-provider-azure-verify
  • pull-cluster-api-provider-azure-apidiff

In response to this:

/retest pull-cluster-api-provider-azure-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@devigned
Copy link
Contributor

/test pull-cluster-api-provider-azure-e2e

@CecileRobertMichon
Copy link
Contributor

@devigned all E2E is failing at the moment due to https://status.quay.io/

https://kubernetes.slack.com/archives/CEX9HENG7/p1590681565302700

@devigned
Copy link
Contributor

yeah... I opened slack right after kicking the job off.

@CecileRobertMichon
Copy link
Contributor

/retest

CecileRobertMichon
CecileRobertMichon approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

thanks @alexander-demichev !

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demichev, CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2020
@CecileRobertMichon
Copy link
Contributor

/assign @devigned
/assign @nader-ziada
for final lgtm

devigned
devigned approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@CecileRobertMichon
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit c0d09b2 into kubernetes-sigs:master May 29, 2020
@k8s-ci-robot k8s-ci-robot added this to the v0.5 milestone May 29, 2020
@alexander-demicev alexander-demicev mentioned this pull request Mar 8, 2021
Closed
6 tasks
This was referenced Apr 6, 2021
Closed
Closed
@CecileRobertMichon CecileRobertMichon mentioned this pull request Apr 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon approved these changes

@devigned devigned devigned approved these changes

@nader-ziada nader-ziada Awaiting requested review from nader-ziada

Assignees

@devigned devigned

@nader-ziada nader-ziada

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4.x
Development

Successfully merging this pull request may close these issues.
5 participants
@alexander-demicev @k8s-ci-robot @nader-ziada @devigned @CecileRobertMichon