-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add patches fields for AKS resources #4527
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4527 +/- ##
==========================================
+ Coverage 62.44% 62.49% +0.04%
==========================================
Files 192 192
Lines 15379 15453 +74
==========================================
+ Hits 9604 9657 +53
- Misses 5115 5129 +14
- Partials 660 667 +7 ☔ View full report in Codecov by Sentry. |
This is ready for review but we still need to wait for consensus on the proposal first. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a few minor non-blocking comments from my end.
/hold also for squash in addition to the proposal |
/test pull-cluster-api-provider-azure-e2e-aks |
/retest |
Looks like all tests are green! Feel free to remove the hold whenever you're ready to merge /lgtm |
LGTM label has been added. Git tree hash: fcd3eabcccacc0f318d5c859c989d9e025351c1c
|
Actually, please squash your commits first, LGTM otherwise. /approve cancel |
Not blocking, but a nice to have would be some kind of addition in the docs of how to patch (e.g. use asoctl to export/compare). If not in this PR, then would be good to add a new docs issue accordingly. |
I'll plan to document this as part of #4568. |
/lgtm++ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
// ASOManagedClusterPatches defines JSON merge patches to be applied to the generated ASO ManagedCluster resource. | ||
// WARNING: This is meant to be used sparingly to enable features for development and testing that are not | ||
// otherwise represented in the CAPZ API. Misconfiguration that conflicts with CAPZ's normal mode of | ||
// operation is possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This warning is well-worded. 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR still needs squash.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
squashed! |
What type of PR is this?
/kind feature
What this PR does / why we need it: This implements #4304 for AzureManagedControlPlane by adding
spec.asoManagedClusterPatches
and for AzureManagedMachinePool by addingspec.asoManagedClustersAgentPoolPatches
to allow users to specify arbitrary patches to apply to those ASO resources.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #3629
Special notes for your reviewer:
TODOs:
Release note: