AzureManagedMachinePool ValidateDelete Webhook will check AMMP for DeleteForMoveAnnotation annotation

[nawazkh]

What type of PR is this?
/kind bug

What this PR does / why we need it:

• AzureManagedMachinePool will check ammp.annotations for DeleteForMoveAnnotation during clusterctl move --to-kubeconfig operation

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4341

Special notes for your reviewer:

• cherry-pick candidate

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

AzureManagedMachinePool will check its annotations for `DeleteForMoveAnnotation` during clusterctl move operation

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[codecov]

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (ad30f63) 61.02% compared to head (cd5ba59) 61.04%.

Files	Patch %	Lines
api/v1beta1/azuremanagedmachinepool_webhook.go	50.00%	2 Missing ⚠️
...v1beta1/azuremanagedmachinepooltemplate_webhook.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4392      +/-   ##
==========================================
+ Coverage   61.02%   61.04%   +0.01%     
==========================================
  Files         190      190              
  Lines       19029    19029              
==========================================
+ Hits        11613    11616       +3     
+ Misses       6784     6782       -2     
+ Partials      632      631       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[CecileRobertMichon]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 045b1e226d2f71279f86192d2c7ab2b1e990fd9b

[nojnhuh]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nojnhuh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nojnhuh]

@nawazkh Feel free to summon the cherry-pick bot for whichever branches we need.

[nawazkh]

/cherry-pick release-1.12

[k8s-infra-cherrypick-robot]

@nawazkh: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nawazkh]

@CecileRobertMichon @nojnhuh , I wonder if this PR should also be cherry-picked onto release-1.11 branch as well.

I see that CAPI added DeleteForMoveAnnotation in Release-1.5.
https://github.com/kubernetes-sigs/cluster-api/blob/8c12f985c9fb9ac6955b2c14f6320046bc7e2f37/cmd/clusterctl/api/v1alpha3/annotations.go#L33

And since CAPZ consumes CAPI-1.5 in CAPZ-1.11, I want to cherry-pick this PR onto release-1.11 as well.

cluster-api-provider-azure/go.mod

Line 55 in e3c702c

sigs.k8s.io/cluster-api v1.5.4

But can someone tell me why the earlier PR (#3426) not added to release-1.11 of CAPZ? Am I missing anything?

[CecileRobertMichon]

AFAIK #3426 wasn't cherry picked because it wasn't technically a "bug fix".

We could cherry-pick this one in release-1.11, although 1.11 doesn't have the regression, even if it's not optimal, it still works.

[k8s-infra-cherrypick-robot]

@nawazkh: new pull request created: #4396

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nawazkh]

#3426 wasn't cherry picked because it wasn't technically a "bug fix".

Hmm.. makes sense. This PR is mostly an "enhancement" than a bug fix. I am ok on not cherry-picking this onto release-1.11.