Move VNet Reconciliation to the Cluster Actuator #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vannrt
suggested changes
Oct 29, 2018
There was a problem hiding this comment.
Looks good to me overall. You need to update the unit test names however. The Makefile only considers tests with the pattern Test(\w)*Unit to be unit tests.
I believe the previous PR also had the same issue (though I didn't catch them that time). I'll take this up. I'll take the unit test issue regarding the previous PR.
| @@ -79,6 +81,16 @@ func (azure *AzureClusterClient) Reconcile(cluster *clusterv1.Cluster) error { | |||
| if err != nil { | |||
| return fmt.Errorf("error waiting for network security group creation or update: %v", err) | |||
| } | |||
|
|
|||
| // Reconcile virutal network | |||
vannrt
previously approved these changes
Oct 29, 2018
karthikbalasub
pushed a commit
to karthikbalasub/cluster-api-provider-azure-1
that referenced
this pull request
Dec 16, 2022
…ig_validation fix kubeletconfig validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves handling of VNets from the machine actuator to the cluster actuator.
Machines in the same cluster are all connected to the same virtual network and each has its own NIC.
Closes #9