Set httpPutResponseHopLimit to 2 when creating instances #4250

wyike · 2023-05-08T01:20:07Z

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4247

Special notes for your reviewer:
Set default httpPutResponseHopLimit as 2 when creating instances
Keep crd default value as 1, in case that customers want to set it as 1 for some machine deployment

Checklist:

squashed commits
includes documentation
adds unit tests
adds or updates e2e tests

Release note:

Set default httpPutResponseHopLimit to 2 in IMDSv2 enablement when creating instances

Ankitasw · 2023-05-08T06:43:32Z

/test pull-cluster-api-provider-aws-e2e

Ankitasw · 2023-05-08T06:47:08Z

@pydctw please add release note anytime a new PR is raised.

Skarlso · 2023-05-08T07:04:06Z

...tructure-aws/withoutclusterclass/kustomize_sources/addons/csi/data/aws-ebs-csi-external.yaml

@@ -4,8 +4,8 @@ metadata:
  name: aws-secret
  namespace: kube-system
 stringData:
-  key_id: ${AWS_ACCESS_KEY_ID}


I remember there was a discussion around this, but it's worth noting why these have been deleted?

Meh. I can't find it. I swear someone explained why that was removed. :D

I guess the test failures are because of that (except for MD remediation which is already failing)
@wyike could you please revert this change, or maybe find a solution such that other tests passes.

comment here: #4147 (comment)

It should be removed. After it is removed, the csi add on will fallback to workload cluster control plane instance role to get credentials from metadata service. Otherwise we cannot catch bugs on this scenario if using explict aws credentails.

It is also not existing in the original csi addon test. At that time, it uses IMDSv1 to retrieve credentials.
After the #4147, the IMDSv2 is enabled however the hop limit is set to 1, csi addon is failed to retrieve credentials hence at that time #4147 add explict aws credentails in the yaml to let tests pass.

I'll take some time to figure out the failure tests.

Hi @Ankitasw @Skarlso I believe there is some bug existing on usage of csi + instance profile role usage. The statefulset is failing to start after node rolls updated and csi becomes out of the tree. I am not very familiar on csi, it will more time to investigate.

I report another issue #4260 and will work on that.

Could you help review this change again, because the downstream product capa bump would need it, thanks a lot!

wyike · 2023-05-10T09:18:51Z

/test pull-cluster-api-provider-aws-e2e

wyike · 2023-05-10T12:54:43Z

/test pull-cluster-api-provider-aws-e2e

Skarlso · 2023-05-10T13:07:50Z

The remediation test is sadly expected to fail. Anything else might be of more interest to you.

k8s-ci-robot · 2023-05-10T15:34:55Z

@wyike: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-aws-e2e	`95978bc`	link	false	`/test pull-cluster-api-provider-aws-e2e`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

wyike · 2023-05-10T15:46:48Z

Hi @Skarlso all tests pass except for the remediation test.
Could you help review and approve, thanks

Skarlso · 2023-05-10T16:00:43Z

/lgtm
/approve

k8s-ci-robot · 2023-05-10T16:00:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Skarlso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Skarlso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

wyike · 2023-05-22T04:47:33Z

/cherry-pick release-2.1

k8s-infra-cherrypick-robot · 2023-05-22T04:48:09Z

@wyike: new pull request created: #4280

In response to this:

/cherry-pick release-2.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot requested review from AverageMarcus and dlipovetsky May 8, 2023 01:20

wyike force-pushed the fix-instance-metadata branch from 5fcaaea to c70c32b Compare May 8, 2023 01:22

wyike marked this pull request as draft May 8, 2023 02:54

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2023

wyike marked this pull request as ready for review May 8, 2023 05:40

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2023

k8s-ci-robot requested a review from pydctw May 8, 2023 05:41

Ankitasw added kind/bug Categorizes issue or PR as related to a bug. and removed kind/feature Categorizes issue or PR as related to a new feature. labels May 8, 2023

Skarlso reviewed May 8, 2023

View reviewed changes

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 9, 2023

wyike force-pushed the fix-instance-metadata branch from c70c32b to e8bf81a Compare May 10, 2023 09:16

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 10, 2023

Set httpPutResponseHopLimit to 2 when creating instances

95978bc

wyike force-pushed the fix-instance-metadata branch from e8bf81a to 95978bc Compare May 10, 2023 09:18

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 10, 2023

k8s-ci-robot assigned Skarlso May 10, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2023

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2023

k8s-ci-robot merged commit 32c475c into kubernetes-sigs:main May 10, 2023

wyike deleted the fix-instance-metadata branch May 10, 2023 17:40

wyike mentioned this pull request May 10, 2023

Zero csi driver aws credentials to fallback to use instance profile role #4262

Merged

4 tasks

k8s-infra-cherrypick-robot mentioned this pull request May 22, 2023

[release-2.1] Set httpPutResponseHopLimit to 2 when creating instances #4280

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set httpPutResponseHopLimit to 2 when creating instances #4250

Set httpPutResponseHopLimit to 2 when creating instances #4250

wyike commented May 8, 2023 •

edited

Loading

Ankitasw commented May 8, 2023

Ankitasw commented May 8, 2023

Skarlso May 8, 2023

Skarlso May 8, 2023

Ankitasw May 8, 2023

wyike May 9, 2023

wyike May 9, 2023 •

edited

Loading

wyike May 10, 2023 •

edited

Loading

wyike commented May 10, 2023

wyike commented May 10, 2023

Skarlso commented May 10, 2023

k8s-ci-robot commented May 10, 2023

wyike commented May 10, 2023

Skarlso commented May 10, 2023

k8s-ci-robot commented May 10, 2023

wyike commented May 22, 2023

k8s-infra-cherrypick-robot commented May 22, 2023

Set httpPutResponseHopLimit to 2 when creating instances #4250

Set httpPutResponseHopLimit to 2 when creating instances #4250

Conversation

wyike commented May 8, 2023 • edited Loading

Ankitasw commented May 8, 2023

Ankitasw commented May 8, 2023

Skarlso May 8, 2023

Choose a reason for hiding this comment

Skarlso May 8, 2023

Choose a reason for hiding this comment

Ankitasw May 8, 2023

Choose a reason for hiding this comment

wyike May 9, 2023

Choose a reason for hiding this comment

wyike May 9, 2023 • edited Loading

Choose a reason for hiding this comment

wyike May 10, 2023 • edited Loading

Choose a reason for hiding this comment

wyike commented May 10, 2023

wyike commented May 10, 2023

Skarlso commented May 10, 2023

k8s-ci-robot commented May 10, 2023

wyike commented May 10, 2023

Skarlso commented May 10, 2023

k8s-ci-robot commented May 10, 2023

wyike commented May 22, 2023

k8s-infra-cherrypick-robot commented May 22, 2023

wyike commented May 8, 2023 •

edited

Loading

wyike May 9, 2023 •

edited

Loading

wyike May 10, 2023 •

edited

Loading