-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing configuration to enable the awsmachinetemplate validating webhook #4117
Add missing configuration to enable the awsmachinetemplate validating webhook #4117
Conversation
Hi @cnmcavoy. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4e0ba0e
to
93895e7
Compare
/ok-to-test |
93895e7
to
6211af1
Compare
879ff04
to
152e56c
Compare
152e56c
to
d790699
Compare
/retest |
/test pull-cluster-api-provider-aws-e2e |
/test pull-cluster-api-provider-aws-e2e-eks |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ankitasw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Enables the AWSMachineTemplate validating webhook. Unclear why it was not previously configured.
The CloudInit behavior was removed, as it was copied from the v1alpha4 resources in c09f55f8f2249d9fde6d7878a6595bf1c4672ff2 and kept being dragged forward, but the comment indicates it was only needed for one resource version upgrade, so I think it's no longer necessary.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #4116
Special notes for your reviewer:
Checklist:
Release note: