Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump ginkgo version #4087

Merged
merged 1 commit into from
Feb 28, 2023
Merged

chore: Bump ginkgo version #4087

merged 1 commit into from
Feb 28, 2023

Conversation

Ankitasw
Copy link
Member

@Ankitasw Ankitasw commented Feb 20, 2023 •
edited
Loading

What type of PR is this?
/kind support

What this PR does / why we need it:
This PR bumps ginkgo to v2.8.4. Also removed the dependency for ginkgo from /hack/tools. Refer here for more details.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/support Categorizes issue or PR as a support question. labels Feb 20, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 20, 2023
@Ankitasw
Copy link
Member Author

/retest

@Ankitasw Ankitasw added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 20, 2023
@Ankitasw
Copy link
Member Author

Ankitasw commented Feb 24, 2023 •
edited
Loading

@richardcase @Skarlso can someone help fix this error 😞
If it had import cycle issues, build would itself fail. But this is failing only in make lint

@Ankitasw Ankitasw force-pushed the bump-ginkgo branch 2 times, most recently from 2086ab4 to bb5735b Compare February 24, 2023 09:49
@Ankitasw Ankitasw mentioned this pull request Feb 24, 2023
Closed
@Skarlso
Copy link
Contributor

Skarlso commented Feb 24, 2023

I'll take a look.
/assign

Skarlso
Skarlso reviewed Feb 24, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@Skarlso
Copy link
Contributor

Skarlso commented Feb 24, 2023

Removing the tools build tag from golangci-lint will fix the lint issue. Testing doesn't use the tools tag as far as I can see.

@Skarlso
Copy link
Contributor

Skarlso commented Feb 25, 2023

We can bump to the next version according to this comment: onsi/ginkgo#1149 (comment)

@Ankitasw
Copy link
Member Author

Ankitasw commented Feb 25, 2023 •
edited
Loading

I will try it out on Monday. Thanks @Skarlso

@Ankitasw Ankitasw force-pushed the bump-ginkgo branch 3 times, most recently from 4e1c88c to b215b15 Compare February 27, 2023 05:48
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 27, 2023
@Ankitasw
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2023
@Ankitasw
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

@Ankitasw
Copy link
Member Author

PR is ready for review.

@Ankitasw
Copy link
Member Author

@Skarlso can I get 👀 on this 🙂 ?

@Skarlso
Copy link
Contributor

Skarlso commented Feb 28, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Skarlso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit 64827bf into kubernetes-sigs:main Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skarlso Skarlso Skarlso left review comments

@dthorsen dthorsen Awaiting requested review from dthorsen

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@Skarlso Skarlso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/support Categorizes issue or PR as a support question. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ankitasw @Skarlso @k8s-ci-robot