Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CCM tag to routing tables #3838

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Nov 10, 2022

/kind feature

What this PR does / why we need it:

Add CCM tag to routing tables.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3532

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 10, 2022
@k8s-ci-robot k8s-ci-robot added needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 10, 2022
@Ankitasw
Copy link
Member

/test pull-cluster-api-provider-aws-e2e

@Ankitasw
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankitasw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit 9bf3384 into kubernetes-sigs:main Nov 10, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.x milestone Nov 10, 2022
@dlipovetsky
Copy link
Contributor

dlipovetsky commented Nov 11, 2022

I think this might be incomplete.

Since we already apply the tag to existing subnets, and, as of #3844, we will apply the tag to existing (i.e. override) security groups, then we also want to apply the tag to user-created route tables.

However, this PR does not apply the tag to user-created route tables, only ones created by CAPA.

[Update: This PR is complete. In fact, CAPA should not apply the CCM tag to user-created route tables, unless it also removes the tag on cluster delete. Please see the issue I filed in #3854]

@Skarlso
Copy link
Contributor Author

Skarlso commented Nov 11, 2022

Thank you @dlipovetsky! I will create a follow up PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tagging route tables with CCM tag
4 participants