-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EventBridge ec2 event reconciliation and rule creation to eks managed control planes #3752
Add EventBridge ec2 event reconciliation and rule creation to eks managed control planes #3752
Conversation
Hi @cnmcavoy. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/test pull-cluster-api-provider-aws-e2e-eks |
/retest |
@cnmcavoy could you please take care of failing E2E test? |
/retest |
@Ankitasw not sure why there is a failing test, this PR is a dead code path for e2e, the event bridge feature gate is not active in any of the e2e eks tests as far as I can tell. |
@Ankitasw the e2e test succeeded on a retry, it is just flaky I guess. |
@cnmcavoy it would be good to test this in E2E. could you please enable |
f23771b
to
56973b0
Compare
…aged control planes
56973b0
to
5ac3588
Compare
Rebased and added to the eks e2e. |
/test pull-cluster-api-provider-aws-e2e-eks |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ankitasw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
The EventBridge feature for importing ec2 events is not supported for EKS in the AWS managed control planes controller. The logic to reconcile the events and create any roles/policies needed is missing.
Special notes for your reviewer:
Slack context: https://kubernetes.slack.com/archives/CD6U2V71N/p1663962497725469
Checklist: