Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EventBridge ec2 event reconciliation and rule creation to eks managed control planes #3752

Merged

Conversation

cnmcavoy
Copy link
Contributor

@cnmcavoy cnmcavoy commented Sep 26, 2022

What type of PR is this?
/kind bug

What this PR does / why we need it:

The EventBridge feature for importing ec2 events is not supported for EKS in the AWS managed control planes controller. The logic to reconcile the events and create any roles/policies needed is missing.

Special notes for your reviewer:
Slack context: https://kubernetes.slack.com/archives/CD6U2V71N/p1663962497725469

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 26, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 26, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @cnmcavoy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 26, 2022
@Ankitasw
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 27, 2022
@Ankitasw
Copy link
Member

/test pull-cluster-api-provider-aws-e2e-eks

@cnmcavoy
Copy link
Contributor Author

/retest

@Ankitasw
Copy link
Member

@cnmcavoy could you please take care of failing E2E test?

@cnmcavoy
Copy link
Contributor Author

/retest

@cnmcavoy
Copy link
Contributor Author

@Ankitasw not sure why there is a failing test, this PR is a dead code path for e2e, the event bridge feature gate is not active in any of the e2e eks tests as far as I can tell.

@cnmcavoy
Copy link
Contributor Author

@Ankitasw the e2e test succeeded on a retry, it is just flaky I guess.

@Ankitasw
Copy link
Member

Ankitasw commented Oct 20, 2022

@cnmcavoy it would be good to test this in E2E. could you please enable EVENT_BRIDGE_INSTANCE_STATE in
https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/f23771b6b1cb6022e755c18d9f3f8d07465806fc/test/e2e/data/e2e_eks_conf.yaml and run the eks tests again?
Otherwise, LGTM.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2022
@cnmcavoy cnmcavoy force-pushed the cnmcavoy/eventbridge-eks branch from f23771b to 56973b0 Compare October 24, 2022 17:35
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2022
@cnmcavoy cnmcavoy force-pushed the cnmcavoy/eventbridge-eks branch from 56973b0 to 5ac3588 Compare October 24, 2022 17:37
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2022
@cnmcavoy
Copy link
Contributor Author

Rebased and added to the eks e2e.

@Ankitasw
Copy link
Member

/test pull-cluster-api-provider-aws-e2e-eks

@Ankitasw
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankitasw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2022
@k8s-ci-robot k8s-ci-robot merged commit 82f2c7f into kubernetes-sigs:main Oct 25, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.x milestone Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants