Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[E2E] Added tests for using filters in AWSResourceReference type fields #3382

Merged
merged 1 commit into from
Apr 19, 2022
Merged

[E2E] Added tests for using filters in AWSResourceReference type fields #3382

merged 1 commit into from
Apr 19, 2022

Conversation

Ankitasw
Copy link
Member

@Ankitasw Ankitasw commented Apr 4, 2022 •
edited
Loading

What type of PR is this?
/area testing

What this PR does / why we need it:
This PR adds the E2E tests for usage of filters in AWSResourceReference type fields. It also adds comments to tests/manifests for the tests that are combined/overloaded with other existing tests.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3348

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Apr 4, 2022
@k8s-ci-robot
Copy link
Contributor

@Ankitasw: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 4, 2022
@k8s-ci-robot k8s-ci-robot requested review from pydctw and shivi28 April 4, 2022 09:04
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 4, 2022
@Ankitasw
Copy link
Member Author

Ankitasw commented Apr 4, 2022 •
edited
Loading

cc @richardcase @sedefsavas I have added usage for filters and ID for Subnet and AdditionalSecurityGroups, I was checking if same can be added for AWSMachinePool tests as well, but those are CAPI tests and not sure how feasible is to create external resources in those tests. If you have any thoughts for the same, please feel free to comment.

@Ankitasw Ankitasw force-pushed the e2e-with-resourceref-filters branch from baa49eb to aa02136 Compare April 4, 2022 11:12
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 4, 2022
@Ankitasw Ankitasw force-pushed the e2e-with-resourceref-filters branch from aa02136 to 6747ad5 Compare April 4, 2022 11:13
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 4, 2022
@Ankitasw Ankitasw force-pushed the e2e-with-resourceref-filters branch 3 times, most recently from eae9b03 to 60aab21 Compare April 7, 2022 10:56
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 9, 2022
@Ankitasw Ankitasw force-pushed the e2e-with-resourceref-filters branch from 60aab21 to 8cbdb38 Compare April 19, 2022 06:34
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2022
@Ankitasw Ankitasw changed the title [WIP] [E2E] Added tests for using filters and IDs in AWSResourceReference type fields [WIP] [E2E] Added tests for using filters in AWSResourceReference type fields Apr 19, 2022
@Ankitasw Ankitasw force-pushed the e2e-with-resourceref-filters branch from 8cbdb38 to 1d81b06 Compare April 19, 2022 07:08
@Ankitasw
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

@Ankitasw Ankitasw force-pushed the e2e-with-resourceref-filters branch from 1d81b06 to 70748cd Compare April 19, 2022 10:26
@Ankitasw
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

@Ankitasw Ankitasw changed the title [WIP] [E2E] Added tests for using filters in AWSResourceReference type fields [E2E] Added tests for using filters in AWSResourceReference type fields Apr 19, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 19, 2022
@Ankitasw
Copy link
Member Author

This PR is ready for review.

@sedefsavas
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sedefsavas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2022
@k8s-ci-robot k8s-ci-robot merged commit 2082599 into kubernetes-sigs:main Apr 19, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.x milestone Apr 19, 2022
@Ankitasw Ankitasw deleted the e2e-with-resourceref-filters branch April 19, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pydctw pydctw Awaiting requested review from pydctw

@shivi28 shivi28 Awaiting requested review from shivi28

Assignees

@sedefsavas sedefsavas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[E2E] Add tests for all the fields of type AWSResourceReference with filters as input
3 participants
@Ankitasw @k8s-ci-robot @sedefsavas