-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block ELB re-creation after the cluster has been provisioned #3240
Conversation
@Ankitasw: This issue is currently awaiting triage. If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-provider-aws-e2e |
73679f0
to
b2d895c
Compare
/test pull-cluster-api-provider-aws-e2e |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sedefsavas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Since ELB is created only when it's not found, this PR blocks the ELB creation in the scenario where if user deletes ELB post the cluster has been provisioned. The reason to do this is if ELB is created again after the cluster has been provisioned, then CAPA will create new ELB with new DNS endpoint which won't work.
As
AWSClusterSpec.ControlPlaneEndpoint
becomes immutable after cluster is provisioned, we are relying on the validity of this endpoint to know the status of provisioning of the cluster to check whether ELB has to be created or not. If this endpoint is valid and ELB is not found, then we inform the user that AWSCluster is in failed state and unrecoverable.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2608
Checklist:
Release note: