Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functions for building infra in AWS #3237

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

josh-ferrell
Copy link

@josh-ferrell josh-ferrell commented Feb 18, 2022

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add some basic CRUD functions for VPCs, subnets, NatGW, IGW, route tables, routes and peering connections to be used by the e2e test suite for building out infrastructure prior to test.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3235

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

Added AWS EC2 Service functions for use by e2e tests.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 18, 2022
@k8s-ci-robot
Copy link
Contributor

@josh-ferrell: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 18, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @josh-ferrell. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 18, 2022
@Ankitasw
Copy link
Member

Hey @josh-ferrell, Thanks for the PR.
Are we planning to have getters for all the above mentioned resources as well, as I see them only for subnets and NATGateways?

@josh-ferrell
Copy link
Author

@Ankitasw I have them in there for VPC, Subnet, NAT GW, IGW and route tables. I can add GET for peering connections but I'm not sure about individual routes. If so I can add that as well.

@Ankitasw
Copy link
Member

@josh-ferrell Hey thanks for pointing out, I think I missed checking NAT gateways and route table thats why asked. I don't think we need for peering connections and individual routes.
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 22, 2022
@josh-ferrell
Copy link
Author

/retest-required

@Ankitasw
Copy link
Member

Ankitasw commented Feb 22, 2022

@josh-ferrell I think you need to run make lint locally to check and fix lint errors which are failing here.

@josh-ferrell
Copy link
Author

Thanks @Ankitasw I think that should take care of it.

Passing context to remaining functions

style fixes
return result.Subnets[0], nil
}

func CreateSubnet(e2eCtx *E2EContext, subnetName string, cidrBlock string, az string, vpcID string) (*ec2.Subnet, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We add CCM tags automatically to unmanaged Subnets, in case want to make this more similar. Not required for this PR. Just FYI.

In summary, to identify a cluster's subnets, CCM looks for the following tags:​

  • kubernetes.io/cluster/YOUR-CLUSTER-NAME=shared/owned (shared value allows more than one cluster to use the subnet)​

  • kubernetes.io/role/elb (for public subnet)​

  • kubernetes.io/role/internal-elb (for private subnet)

@sedefsavas
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sedefsavas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2022
@sedefsavas sedefsavas added this to the v1.4.0 milestone Feb 22, 2022
@Ankitasw
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit f5b009e into kubernetes-sigs:main Feb 23, 2022
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.4.0, v1.x Feb 23, 2022
@josh-ferrell josh-ferrell deleted the aws-infra-functions branch February 24, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AWS Service functions to e2e test shared
4 participants