-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added functions for building infra in AWS #3237
Added functions for building infra in AWS #3237
Conversation
@josh-ferrell: This issue is currently awaiting triage. If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @josh-ferrell. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hey @josh-ferrell, Thanks for the PR. |
@Ankitasw I have them in there for VPC, Subnet, NAT GW, IGW and route tables. I can add GET for peering connections but I'm not sure about individual routes. If so I can add that as well. |
@josh-ferrell Hey thanks for pointing out, I think I missed checking NAT gateways and route table thats why asked. I don't think we need for peering connections and individual routes. |
/retest-required |
@josh-ferrell I think you need to run |
Thanks @Ankitasw I think that should take care of it. |
Passing context to remaining functions style fixes
7f660dc
to
3aaccd9
Compare
return result.Subnets[0], nil | ||
} | ||
|
||
func CreateSubnet(e2eCtx *E2EContext, subnetName string, cidrBlock string, az string, vpcID string) (*ec2.Subnet, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We add CCM tags automatically to unmanaged Subnets, in case want to make this more similar. Not required for this PR. Just FYI.
In summary, to identify a cluster's subnets, CCM looks for the following tags:
-
kubernetes.io/cluster/YOUR-CLUSTER-NAME=shared/owned (shared value allows more than one cluster to use the subnet)
-
kubernetes.io/role/elb (for public subnet)
-
kubernetes.io/role/internal-elb (for private subnet)
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sedefsavas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add some basic CRUD functions for VPCs, subnets, NatGW, IGW, route tables, routes and peering connections to be used by the e2e test suite for building out infrastructure prior to test.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #3235
Special notes for your reviewer:
Checklist:
Release note: