Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categorize events to distinguish between create/delete events. #1344

Closed
harishspqr opened this issue Nov 8, 2019 · 7 comments
Closed

Categorize events to distinguish between create/delete events. #1344

harishspqr opened this issue Nov 8, 2019 · 7 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone

Comments

@harishspqr
Copy link
Contributor

/kind feature

Describe the solution you'd like
Currently events are generated on Machines/Clusters but not enough metadata is available as to what type of event it is. We would like to categorize if events are related to creating or deleting the resources.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Cluster-api-provider-aws version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 8, 2019
@vincepri
Copy link
Member

/milestone v0.5.0
/priority important-longterm
/help

@k8s-ci-robot
Copy link
Contributor

@vincepri:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/milestone v0.5.0
/priority important-longterm
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v0.5.0 milestone Nov 11, 2019
@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Nov 11, 2019
@noamran
Copy link
Contributor

noamran commented Nov 11, 2019

/assign

@joonas
Copy link

joonas commented Dec 20, 2019

Also being discussed in CAPI: kubernetes-sigs/cluster-api#1743

@noamran noamran removed their assignment Jan 8, 2020
@ncdc
Copy link
Contributor

ncdc commented Jan 17, 2020

@k8s-ci-robot k8s-ci-robot modified the milestones: v0.5.0, Next Jan 17, 2020
@vincepri
Copy link
Member

Closing in favor of condition work in next cycle

/close

@k8s-ci-robot
Copy link
Contributor

@vincepri: Closing this issue.

In response to this:

Closing in favor of condition work in next cycle

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

6 participants