Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add CAPI API version upgrade test #165

Merged
merged 3 commits into from
Feb 2, 2024
Merged

✨ Add CAPI API version upgrade test #165

merged 3 commits into from
Feb 2, 2024

Conversation

Jont828
Copy link
Contributor

@Jont828 Jont828 commented Feb 1, 2024 •
edited
Loading

What this PR does / why we need it: Add CAPI API version upgrade test (not K8s version). Not sure yet if this will work or not.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 1, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 1, 2024
@Jont828 Jont828 changed the title ✨ Add CAPI APIVersion upgrade test ✨ Add CAPI API Version upgrade test Feb 1, 2024
@Jont828 Jont828 changed the title ✨ Add CAPI API Version upgrade test ✨ Add CAPI API version upgrade test Feb 1, 2024
@Jont828 Jont828 force-pushed the apiversion-upgrade-test branch 2 times, most recently from 2846e60 to 8c154ba Compare February 1, 2024 22:43
@Jont828 Jont828 force-pushed the apiversion-upgrade-test branch from 8c154ba to ece2188 Compare February 1, 2024 22:45
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 1, 2024
@Jont828 Jont828 force-pushed the apiversion-upgrade-test branch from 296967d to bf3998d Compare February 1, 2024 22:55
@Jont828
Copy link
Contributor Author

Jont828 commented Feb 2, 2024

@mboersma

mboersma
mboersma approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jont828, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2428230 into kubernetes-sigs:main Feb 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboersma mboersma mboersma approved these changes

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees

@mboersma mboersma

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jont828 @k8s-ci-robot @mboersma