🐛 Fix nil pointer bug in EnableClientCache option #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jont828 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Jont828
changed the title
k8s-ci-robot
added
the
size/XS
|
@sebltm I was running into a nil pointer exception in the defaulting logic for EnableClientCache when Helm options was nil. I think we should probably move that logic to the webhook or kubebuilder validation, but I opened a quick fix for now to get things working again. |
Jont828
force-pushed
the
credentials-nil-pointer-fix
branch
from
6b79e37 to
e41d8e2
Compare
mboersma
reviewed
Jan 18, 2024
Jont828
force-pushed
the
credentials-nil-pointer-fix
branch
from
e41d8e2 to
8f5a31f
Compare
k8s-ci-robot
added
size/S
Jont828
force-pushed
the
credentials-nil-pointer-fix
branch
from
8f5a31f to
1aad4d0
Compare
|
@mboersma Lint issue fixed! |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Fixes a bug in #136 where a nil pointer exception was occurring in constructing the HelmReleaseProxy if Helm options was left blank.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #