-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add support for the ObservedGeneration in HelmChartProxy Status field #145
✨ Add support for the ObservedGeneration in HelmChartProxy Status field #145
Conversation
Welcome @dmvolod! |
Hi @dmvolod. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Please note, that update test can be implemented as real reconcile test with setup-envtest and will be fixed as part of the #146 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly seems reasonable to me. I want to wait for #147 to get in so we have an opportunity to test the changes.
/retest |
/lgtm Could you squash your commits before merging? |
Yes, sure. Will do it. |
9965047
to
0d6b80f
Compare
/lgtm Nice work! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmvolod, Jont828 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #144