Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding documentation for CoreDNS operator and building an addon-operator #58

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

rajansandeep
Copy link
Contributor

I've moved around the existing documentation to have:

  • the CoreDNS operator README describe the usage of the operator
  • use and rewrite the README existing in CoreDNS folder as a walkthrough to build an addon operator.

Fixes: #11

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 2, 2020
@k8s-ci-robot k8s-ci-robot requested review from atoato88 and dholbach June 2, 2020 19:20
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 2, 2020
@rajansandeep
Copy link
Contributor Author

I will continue to add bits as things strike me, but please go ahead and suggest things we should add/delete here.

@dholbach
Copy link
Member

dholbach commented Jun 3, 2020

/uncc
/cc @johnsonj

@k8s-ci-robot k8s-ci-robot requested review from johnsonj and removed request for dholbach June 3, 2020 09:04
@justinsb
Copy link
Contributor

justinsb commented Jul 2, 2020

Thanks @rajansandeep - this is really awesome. I love the idea that the walkthrough will produce the real operator that everyone will be running - that really brings home the idea that what we're building here lets people create real operators!

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, rajansandeep

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2020
@rajansandeep
Copy link
Contributor Author

/test pull-cluster-addons-unit-test

@k8s-ci-robot k8s-ci-robot merged commit 6953455 into kubernetes-sigs:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docs to describe how to build addon operators
4 participants