-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: improve autoscaling E2E to prevent unexpected scale operations #5576
test: improve autoscaling E2E to prevent unexpected scale operations #5576
Conversation
Hi @comtalyst. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
013ae94
to
9f88910
Compare
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments.
@comtalyst The PR LGTM. Thank you! |
71a7c74
to
a7aebdc
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: comtalyst, lzhecheng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
/kind flake
What this PR does / why we need it:
Current autoscaling E2Es can be unreliable when trying to catch over-scaling, as it only checks once at the end.
This has resulted in a Cluster Autoscaler image that contains over-scaling issue to get through the check unnoticed.
This PR aims to increase test coverage to cover the case where there are unexpected scale operations during and after standard scaling check.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: