Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ignore errors dumping logs after listing #1936

Merged
merged 1 commit into from
Jun 24, 2022
Merged

fix: Ignore errors dumping logs after listing #1936

merged 1 commit into from
Jun 24, 2022

Conversation

edreed
Copy link
Contributor

@edreed edreed commented Jun 23, 2022 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

Ignores errors dumping logs from ephemeral pods like Job pods. The log may be deleted between the time the log directory is listed and the file is dumped.

Original filed as kubernetes-sigs/azuredisk-csi-driver#1392.

Which issue(s) this PR fixes:

Fixes #1935

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Jun 23, 2022
@k8s-ci-robot
Copy link
Contributor

@edreed: The label(s) kind/test cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind test
/kind bug

What this PR does / why we need it:

Ignores errors dumping logs from ephemeral pods like Job pods. The log may be deleted between the time the log directory is listed and the file is dumped.

Original filed as kubernetes-sigs/azuredisk-csi-driver#1392.

Which issue(s) this PR fixes:

Fixes #1935

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 23, 2022
@netlify
Copy link

netlify bot commented Jun 23, 2022 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.

Name Link
🔨 Latest commit e4ba0d3
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/62b4961a7205ba000850d346

@netlify
Copy link

netlify bot commented Jun 23, 2022 •
edited
Loading

✅ Deploy Preview for warm-cascaron-bb779f canceled.

Name Link
🔨 Latest commit e4ba0d3
🔍 Latest deploy log https://app.netlify.com/sites/warm-cascaron-bb779f/deploys/62b4961a868b8f0008675898

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 23, 2022
@edreed
Copy link
Contributor Author

edreed commented Jun 23, 2022

/retest

andyzhangx
andyzhangx approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, edreed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2022
@k8s-ci-robot k8s-ci-robot merged commit a639e36 into kubernetes-sigs:master Jun 24, 2022
@edreed edreed deleted the edreed-ignore-log-file-not-found branch June 24, 2022 03:54
@edreed edreed mentioned this pull request Jun 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dumping job logs can fail with "file not found"
3 participants
@edreed @k8s-ci-robot @andyzhangx