Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test acs-engine version #18

Merged
merged 1 commit into from
May 24, 2018
Merged

Update test acs-engine version #18

merged 1 commit into from
May 24, 2018

Conversation

karataliu
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 22, 2018
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 22, 2018
@karataliu karataliu changed the title Update test acs-engine version [WIP] Update test acs-engine version May 22, 2018
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 22, 2018
@karataliu
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 22, 2018
@karataliu karataliu force-pushed the ae.new branch 2 times, most recently from 8c33d94 to ee50710 Compare May 22, 2018 08:08
feiskyer
feiskyer reviewed May 22, 2018
View reviewed changes
tests/k8s-azure/Dockerfile
@@ -13,7 +13,7 @@ RUN git clone https://github.com/kubernetes/kubernetes . \
RUN rm -rf _output/local/go

FROM golang:1.8.3-stretch AS build_acs-engine
ARG ACSENGINE_VERSION=v0.14.0
ARG ACSENGINE_VERSION=v0.17.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should always use latest release, the release tag could be get by command:

curl -L -s https://api.github.com/repos/Azure/acs-engine/releases/latest | jq -r .tag_name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest release sometimes have regression such as: Azure/acs-engine#3022 ,which brings all NFS case to failure.

Would prefer manually updating the version, this is like what we do in using fixed os image version inside acs-engine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable

@karataliu
Copy link
Contributor Author

/test pull-cloud-provider-azure-e2e

@karataliu
Copy link
Contributor Author

/retest

@karataliu
Copy link
Contributor Author

/test pull-cloud-provider-azure-e2e

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 23, 2018
@karataliu
Copy link
Contributor Author

/test pull-cloud-provider-azure-e2e

@karataliu karataliu changed the title [WIP] Update test acs-engine version Update test acs-engine version May 24, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 24, 2018
@karataliu
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2018
@karataliu
Copy link
Contributor Author

@feiskyer PTAL

feiskyer
feiskyer reviewed May 24, 2018
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2018
@k8s-ci-robot k8s-ci-robot merged commit 48cf88f into kubernetes-sigs:master May 24, 2018
@karataliu karataliu deleted the ae.new branch May 24, 2018 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

@khenidak khenidak Awaiting requested review from khenidak

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karataliu @k8s-ci-robot @feiskyer