Hotfix: fix probe missing error when updating service whose external traffic policy is local and has multiple ports #1317
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
approved
MartinForReal
force-pushed
the
fix/fix_probe_missing
branch
from
f42a9be to
720b30c
Compare
k8s-ci-robot
added
size/L
…e port opened. Signed-off-by: GitHub <[email protected]>
MartinForReal
force-pushed
the
fix/fix_probe_missing
branch
from
720b30c to
05333d0
Compare
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, MartinForReal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick release-1.23 |
|
@feiskyer: once the present PR merges, I will cherry-pick it on top of release-1.23 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-1.1 |
|
@feiskyer: once the present PR merges, I will cherry-pick it on top of release-1.1 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-1.0 |
|
@feiskyer: once the present PR merges, I will cherry-pick it on top of release-1.0 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-0.7 |
|
@feiskyer: once the present PR merges, I will cherry-pick it on top of release-0.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hey, I'm a bit confused. which aks version this will be available with? i can see you are cherry picking to multiple different releases, but I don't really know what aks version they map to |
|
@4c74356b41 see the version matrix https://github.com/kubernetes-sigs/cloud-provider-azure#current-status (AKS has enabled cloud-controller-manager for versions >=1.22.0) |
|
@feiskyer: new pull request created: #1324 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
merge this commit because e2e tests have been executed for a few times |
|
@feiskyer: new pull request created: #1325 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@feiskyer: new pull request created: #1326 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@feiskyer: new pull request created: #1327 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-1.23 |
|
@MartinForReal: new pull request could not be created: failed to create pull request against kubernetes-sigs/cloud-provider-azure#release-1.23 from head k8s-infra-cherrypick-robot:cherry-pick-1317-to-release-1.23: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for k8s-infra-cherrypick-robot:cherry-pick-1317-to-release-1.23."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-1.23 |
|
@MartinForReal: new pull request created: #1332 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-1.1 |
|
/cherrypick release-1.0 |
|
@MartinForReal: new pull request created: #1333 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@MartinForReal: new pull request created: #1334 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
this only gives part of the answer. so you are merging to 1.23 and 1.1, which corresponds to 1.22 and 1.23 k8s version, but which patch version is that? or when is it going to be available in aks? or what do i need to do to encorporate this fix? |
|
I will be rolled out to all aks regions |
|
all patch versions? when? i assume if it gets retrofitted I'd just need to do smth like: ? |
MartinForReal
changed the title
Signed-off-by: GitHub [email protected]
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: