Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing ["] in pkg/provider/doc.go file. #1158

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Add missing ["] in pkg/provider/doc.go file. #1158

merged 1 commit into from
Feb 18, 2022

Conversation

gandhipr
Copy link
Contributor

@gandhipr gandhipr commented Feb 17, 2022 •
edited by feiskyer
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

adds missing ["] in pkg/provider/doc.go file.

Which issue(s) this PR fixes:

Fixes #
adds missing ["] in pkg/provider/doc.go file.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 17, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @gandhipr!

It looks like this is your first PR to kubernetes-sigs/cloud-provider-azure 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cloud-provider-azure has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 17, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @gandhipr. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 17, 2022
@feiskyer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 18, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.078% when pulling cc822a5 on gandhipr:prachigandhi-fix-pkg-provider-doc.go into bfc511f on kubernetes-sigs:master.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 18, 2022
feiskyer
feiskyer reviewed Feb 18, 2022
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, gandhipr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2022
@nilo19 nilo19 added kind/documentation Categorizes issue or PR as related to documentation. and removed kind/bug Categorizes issue or PR as related to a bug. labels Feb 18, 2022
@nilo19
Copy link
Contributor

nilo19 commented Feb 18, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit 88e2f2e into kubernetes-sigs:master Feb 18, 2022
@MartinForReal
Copy link
Contributor

/cherrypick release-1.23

@MartinForReal
Copy link
Contributor

/cherrypick release-1.1

@MartinForReal
Copy link
Contributor

/cherrypick release-1.0

@MartinForReal
Copy link
Contributor

/cherrypick release-0.7

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Feb 18, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@MartinForReal: new pull request created: #1161

In response to this:

/cherrypick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Feb 18, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@MartinForReal: new pull request created: #1162

In response to this:

/cherrypick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Feb 18, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@MartinForReal: new pull request created: #1163

In response to this:

/cherrypick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Feb 18, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@MartinForReal: new pull request created: #1164

In response to this:

/cherrypick release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gjtempleton gjtempleton mentioned this pull request May 9, 2022
Merged
@marwanad marwanad mentioned this pull request May 10, 2022
Closed
@gandhipr gandhipr mentioned this pull request Sep 9, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@nilo19 nilo19 Awaiting requested review from nilo19

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gandhipr @k8s-ci-robot @feiskyer @coveralls @nilo19 @MartinForReal @k8s-infra-cherrypick-robot