fix: strip service account token #1309
Conversation
|
@cvvz: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
cncf-cla: yes
pkg/csi-common/utils.go
Outdated
| return req.String() | ||
| } | ||
|
|
||
| if _, ok := volumeContext["csi.storage.k8s.io/serviceAccount.tokens"]; !ok { |
There was a problem hiding this comment.
let's make this func more generic, set csi.storage.k8s.io/serviceAccount.tokens as a parameter, thanks.
There was a problem hiding this comment.
rename as stripSecrect(secretFieldNames []string)
There was a problem hiding this comment.
ok, please take another look
There was a problem hiding this comment.
rename as stripSecrect(secretFieldNames []string)
This will be conflict with the protosanitizer.StripSecrets function in csi lib
|
/retest |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, cvvz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/cherrypick release-1.24 |
|
/cherrypick release-1.23 |
|
@andyzhangx: new pull request created: #1310 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@andyzhangx: new pull request created: #1311 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
strip service account token to avoid security risk.
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: