Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide nfsv3 protocol to enforce nfs mount #1276

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Mar 13, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: provide nfsv3 protocol to enforce nfs mount

when we specify protocol: nfsv3 in storage class or pv, this driver would enforce with nfs protocol instead of using aznfs mount by default, that provides a workaround when aznfs mount does not work

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

feat: provide nfsv3 protocol to enforce nfs mount

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 13, 2024
@k8s-ci-robot k8s-ci-robot requested review from cvvz and feiskyer March 13, 2024 11:33
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2024
@cvvz
Copy link
Member

cvvz commented Mar 14, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, cvvz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ac7bf03 into kubernetes-sigs:master Mar 14, 2024
21 checks passed
@andyzhangx
Copy link
Member Author

/cherrypick release-1.24

@andyzhangx
Copy link
Member Author

/cherrypick release-1.23

@andyzhangx
Copy link
Member Author

/cherrypick release-1.22

@k8s-infra-cherrypick-robot

@andyzhangx: #1276 failed to apply on top of branch "release-1.23":

Applying: feat: provide nfsv3 protocol to enforce nfs mount
Using index info to reconstruct a base tree...
M	pkg/blob/blob.go
M	pkg/blob/blob_test.go
M	pkg/blob/controllerserver_test.go
M	pkg/blob/nodeserver.go
M	test/e2e/dynamic_provisioning_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/dynamic_provisioning_test.go
Auto-merging pkg/blob/nodeserver.go
Auto-merging pkg/blob/controllerserver_test.go
Auto-merging pkg/blob/blob_test.go
Auto-merging pkg/blob/blob.go
CONFLICT (content): Merge conflict in pkg/blob/blob.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 feat: provide nfsv3 protocol to enforce nfs mount
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@andyzhangx: #1276 failed to apply on top of branch "release-1.22":

Applying: feat: provide nfsv3 protocol to enforce nfs mount
Using index info to reconstruct a base tree...
M	pkg/blob/blob.go
M	pkg/blob/blob_test.go
M	pkg/blob/controllerserver_test.go
M	pkg/blob/nodeserver.go
M	test/e2e/dynamic_provisioning_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/dynamic_provisioning_test.go
Auto-merging pkg/blob/nodeserver.go
Auto-merging pkg/blob/controllerserver_test.go
Auto-merging pkg/blob/blob_test.go
Auto-merging pkg/blob/blob.go
CONFLICT (content): Merge conflict in pkg/blob/blob.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 feat: provide nfsv3 protocol to enforce nfs mount
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@andyzhangx: new pull request created: #1277

In response to this:

/cherrypick release-1.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants