-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix corrupted mount issue when driver daemonset restarted #117
fix corrupted mount issue when driver daemonset restarted #117
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fix: corrupt mount path doc: add two blobfuse deployments test: fix comment revert utils/mount depenency
53872d4
to
75baa45
Compare
/lgtm |
@andyzhangx Is this support subpath? |
@hhstu the mount path won't be broken now since we are using blobfuse-proxy by default: https://github.com/kubernetes-sigs/blob-csi-driver/tree/master/deploy/blobfuse-proxy |
@andyzhangx ok,Thank you. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR together with an k8s upstream PR(kubernetes/kubernetes#88569) would fix the corrupted mount issue when fuse based CSI driver daemonset is restarted on the node:
after daemonset is restarted, original blobfuse mount is broken, this PR would handle broken mount in both
NodeStage
andNodePublish
Which issue(s) this PR fixes:
Fixes #115
Special notes for your reviewer:
Main fix is in
ensureMountPoint
func:main code exection logic for this PR:
Release note: