chore(cargo workspace): unifies crates as workspace

[EandrewJones]

Changes

Combines all rust crates under a single workspace to simplify management of rust packaging.

Note: All crates are converted to the workspace with the exception of ebpf which needs independent tooling and packages to properly build.

Closes #218

[EandrewJones]

Well I wanted to punt on touching the Makefile and Docker builds, but looks like I may have to anyways since the workspace breaks docker image builds. And if I'm going to do it, I may as well do it the right way.

[EandrewJones]

@astoycos Ready for your review. Apologies for the large PR. Unfortunately, I also had to update the CI, Makefiles, and Dockerfiles to get the test suite passing with the transition to a workspace.

[astoycos]

No worries I'm a bit backed up on the TODO list but I will get to this as soon as I can

[aryan9600]

do we need this in the dataplane?

[EandrewJones]

Unfortunately, we do. If I recall correctly, cargo complains if the referenced workspace members are missing, even if you're only building a single package.

I don't think this is that big of a deal, however, because it doesn't get copied over to the second stage.

If you know a work around, please share.

[EandrewJones]

Let's wait for word from Andrew. Best Evan Jones Website: www.ea-jones.com

…

On Thu, May 30, 2024 at 7:48 AM Sanskar Jaiswal ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In service.dataplane.Dockerfile <#227 (comment)> : > @@ -32,9 +41,13 @@ RUN --mount=type=cache,target=/workspace/target/ \ cargo xtask build-ebpf --release RUN --mount=type=cache,target=/workspace/target/ \ --mount=type=cache,target=/root/.cargo/registry \ - RUSTFLAGS=-Ctarget-feature=+crt-static cargo build --release --target=$(eval cat arch)-unknown-linux-musl + RUSTFLAGS=-Ctarget-feature=+crt-static cargo build \ + --workspace \ + --exclude ebpf \ if the tests are passing, then i must be missing something, please ignore — Reply to this email directly, view it on GitHub <#227 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJ2T6AJXU2T3XIIVMDGBCCDZE4GXPAVCNFSM6AAAAABGOMAFTWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAOBYGA2TANZXGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[astoycos]

Just some small things, additionally can you remove https://github.com/kubernetes-sigs/blixt/blob/main/dataplane/ebpf/Cargo.toml#L36 from the ebpf crate's cargo toml it's not a workspace just a standalone crate

You could also document somewhere that the ebpf crate can't be part of the workspace because

error[E0152]: found duplicate lang item `panic_impl`
   --> dataplane/ebpf/src/main.rs:117:1
    |
117 | / fn panic(_info: &core::panic::PanicInfo) -> ! {
118 | |     loop {}
119 | | }
    | |_^

Or more specifically because the crate needs to re-implements the panic handler

[EandrewJones]

Just some small things, additionally can you remove https://github.com/kubernetes-sigs/blixt/blob/main/dataplane/ebpf/Cargo.toml#L36 from the ebpf crate's cargo toml it's not a workspace just a standalone crate

You could also document somewhere that the ebpf crate can't be part of the workspace because

error[E0152]: found duplicate lang item `panic_impl`
   --> dataplane/ebpf/src/main.rs:117:1
    |
117 | / fn panic(_info: &core::panic::PanicInfo) -> ! {
118 | |     loop {}
119 | | }
    | |_^

Or more specifically because the crate needs to re-implements the panic handler

I added a note in the README.

[astoycos]

/lgtm
/approve

You're the man @EandrewJones!!! Sorry for my slowness on this one

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astoycos, EandrewJones

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [astoycos]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[EandrewJones]

/lgtm /approve

You're the man @EandrewJones!!! Sorry for my slowness on this one

No worries. I'm quite buried myself right now, so I appreciated the slowness ;)