Skip to content

Commit

Permalink
Fix reabse issues
Browse files Browse the repository at this point in the history
  • Loading branch information
levikobi committed Oct 26, 2023
1 parent f385f31 commit 2b2324f
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 57 deletions.
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Build the manager binary
FROM golang:1.20 as builder
FROM golang:1.21 as builder

LABEL org.opencontainers.image.source=https://github.com/kubernetes-sigs/blixt
LABEL org.opencontainers.image.description="An experimental layer 4 load-balancer built using eBPF/XDP with ebpf-go \
Expand Down
31 changes: 3 additions & 28 deletions controllers/tcproute_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -226,39 +226,13 @@ func (r *TCPRouteReconciler) ensureTCPRouteDeletedInDataPlane(ctx context.Contex
return err
}

<<<<<<< HEAD
<<<<<<< HEAD
<<<<<<< HEAD
// TODO: add multiple endpoint support https://github.com/Kong/blixt/issues/46
dataplaneClient, err := dataplane.NewDataPlaneClient(context.Background(), r.Client)
if err != nil {
return err
}

// since we currently only support one TCPRoute per Gateway, we can delete the vip (gateway)
// entry from the dataplane. this won't fly when we end up adding support for multiple TCPRoutes
// per Gateway.
confirmation, err := dataplaneClient.Delete(context.Background(), &dataplane.Vip{
vip := dataplane.Vip{
Ip: gatewayIP,
Port: gwPort,
})
if err != nil {
=======
// delete the target from the dataplane
if _, err = r.BackendsClientManager.Delete(ctx, targets.Vip); err != nil {
>>>>>>> 86c3e7e (Add support for multiple gRPC client management)
=======
// TODO: add multiple endpoint support https://github.com/Kong/blixt/issues/46
dataplaneClient, err := dataplane.NewDataPlaneClient(context.Background(), r.Client)
if err != nil {
>>>>>>> d4cafa8 (Revert "Add support for multiple gRPC client management")
return err
}

=======
>>>>>>> 7bdffd0 (Add dataplane controller and multi gRPC clients manager)
// delete the target from the dataplane
if _, err = r.BackendsClientManager.Delete(ctx, targets.Vip); err != nil {
if _, err = r.BackendsClientManager.Delete(ctx, &vip); err != nil {
return err
}

Expand All @@ -274,4 +248,5 @@ func (r *TCPRouteReconciler) ensureTCPRouteDeletedInDataPlane(ctx context.Contex
tcproute.SetFinalizers(newFinalizers)

return r.Client.Update(ctx, tcproute)

}
30 changes: 2 additions & 28 deletions controllers/udproute_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -226,39 +226,13 @@ func (r *UDPRouteReconciler) ensureUDPRouteDeletedInDataPlane(ctx context.Contex
return err
}

<<<<<<< HEAD
<<<<<<< HEAD
<<<<<<< HEAD
// TODO: add multiple endpoint support https://github.com/Kong/blixt/issues/46
dataplaneClient, err := dataplane.NewDataPlaneClient(context.Background(), r.Client)
if err != nil {
return err
}

// since we currently only support one UDPRoute per Gateway, we can delete the vip (gateway)
// entry from the dataplane. this won't fly when we end up adding support for multiple UDPRoutes
// per Gateway.
confirmation, err := dataplaneClient.Delete(context.Background(), &dataplane.Vip{
vip := dataplane.Vip{
Ip: gatewayIP,
Port: gwPort,
})
if err != nil {
=======
// delete the target from the dataplane
if _, err = r.BackendsClientManager.Delete(ctx, targets.Vip); err != nil {
>>>>>>> 86c3e7e (Add support for multiple gRPC client management)
=======
// TODO: add multiple endpoint support https://github.com/Kong/blixt/issues/46
dataplaneClient, err := dataplane.NewDataPlaneClient(context.Background(), r.Client)
if err != nil {
>>>>>>> d4cafa8 (Revert "Add support for multiple gRPC client management")
return err
}

=======
>>>>>>> 7bdffd0 (Add dataplane controller and multi gRPC clients manager)
// delete the target from the dataplane
if _, err = r.BackendsClientManager.Delete(ctx, targets.Vip); err != nil {
if _, err = r.BackendsClientManager.Delete(ctx, &vip); err != nil {
return err
}

Expand Down

0 comments on commit 2b2324f

Please sign in to comment.