Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade azcopy to 10.21.2 #1553

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

umagnus
Copy link
Contributor

@umagnus umagnus commented Nov 7, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

cleanup: update azcopy 10.21.2

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 7, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @umagnus. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from cvvz and gnufied November 7, 2023 02:41
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 7, 2023
@umagnus umagnus force-pushed the update_azcopy_10.21.2 branch from 5c7d09b to befef71 Compare November 7, 2023 06:40
@umagnus umagnus force-pushed the update_azcopy_10.21.2 branch from befef71 to be13777 Compare November 7, 2023 07:54
@andyzhangx andyzhangx changed the title cleanup: update azcopy 10.21.2 cleanup: upgrade azcopy 10.21.2 Nov 7, 2023
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 7, 2023
@andyzhangx
Copy link
Member

/retest

@andyzhangx andyzhangx changed the title cleanup: upgrade azcopy 10.21.2 feat: upgrade azcopy to 10.21.2 Nov 7, 2023
@andyzhangx
Copy link
Member

/retest

1 similar comment
@umagnus
Copy link
Contributor Author

umagnus commented Nov 8, 2023

/retest

@andyzhangx andyzhangx merged commit 242af46 into kubernetes-sigs:master Nov 8, 2023
10 checks passed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, umagnus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2023
@andyzhangx
Copy link
Member

/cherrypick release-1.29

@andyzhangx
Copy link
Member

/cherrypick release-1.28

@k8s-infra-cherrypick-robot

@andyzhangx: new pull request created: #1555

In response to this:

/cherrypick release-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@andyzhangx: #1553 failed to apply on top of branch "release-1.28":

Applying: update azcopy 10.21.2
Using index info to reconstruct a base tree...
M	.trivyignore
M	pkg/azurefileplugin/Dockerfile
Falling back to patching base and 3-way merge...
Auto-merging pkg/azurefileplugin/Dockerfile
CONFLICT (modify/delete): .trivyignore deleted in update azcopy 10.21.2 and modified in HEAD. Version HEAD of .trivyignore left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 update azcopy 10.21.2
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@umagnus umagnus deleted the update_azcopy_10.21.2 branch June 20, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants