Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable uuid checks on XFS #955

Merged
merged 1 commit into from
Jul 30, 2021

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Jul 30, 2021

What type of PR is this?
/kind bug

What this PR does / why we need it:
Add nouuid mount option to all XFS mounts to be able to mount a volume and its restored snapshot on the same node. Without the option, such a mount fails, because XFS detects that two different volumes with the same filesystem UUID are being mounted.

Which issue(s) this PR fixes:
Fixes #954

Requirements:

  • uses conventional commit messages
  • includes documentation - added release note below
  • adds unit tests - there are no successful / mount option related NodeStage unit tests
  • tested upgrade from previous version

Special notes for your reviewer:

Release note:

It is now possible to mount a volume with XFS filesystem and its restored snapshot on the same node.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 30, 2021
Add 'nouuid' mount option to all XFS mounts to be able to mount a volume
and its restored snapshot on the same node. Without the option, such a
mount fails, because XFS detects that two different volumes with the same
filesystem UUID are being mounted.
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9630adf into kubernetes-sigs:master Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to mount XFS volume + its restored snapshot to the same node
3 participants