Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch to async disk attach/detach #897

Merged
merged 2 commits into from
Jul 28, 2021

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: switch to async disk attach

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

feat: switch to async disk attach

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2021
@andyzhangx
Copy link
Member Author

/test pull-azuredisk-csi-driver-e2e-windows-containerd

@andyzhangx
Copy link
Member Author

/retest

@andyzhangx andyzhangx changed the title [WIP]feat: switch to async disk attach [WIP]feat: switch to async disk attach/detach Jun 24, 2021
@andyzhangx andyzhangx force-pushed the async-attach branch 2 times, most recently from 11c7fc0 to bc7ca0c Compare June 28, 2021 02:06
@andyzhangx
Copy link
Member Author

/test pull-azuredisk-csi-driver-integration

@andyzhangx
Copy link
Member Author

/test pull-azuredisk-csi-driver-e2e-migration-windows

add missing change

unlock

use PatchResourceAsync for vmas

feat: async detach disk

fix detach disk issue

fix

reduce get disk operations in attach disk

fix ut

remove future check

add logging

little refactor

feat: add disk attach/detach rate limit

read rate limit from cloud config

update vendor
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 28, 2021
@andyzhangx andyzhangx changed the title [WIP]feat: switch to async disk attach/detach feat: switch to async disk attach/detach Jul 28, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 28, 2021
@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member Author

/retest

@andyzhangx andyzhangx merged commit 9759544 into kubernetes-sigs:master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants