Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support customization tolerations in chart #887

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Jun 13, 2021

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: support customization tolerations in chart

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

  • example how to set customized tolerations on node:
--set linux.tolerations[0].operator=Exists,linux.tolerations[0].effect=NoSchedule,linux.tolerations[0].key=xxx

Release note:

feat: support customization tolerations  in chart

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 13, 2021
@andyzhangx
Copy link
Member Author

/retest

@andyzhangx andyzhangx merged commit 03d1fd3 into kubernetes-sigs:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants