Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: added check to test ZRS in dynamically provisioned test suite #875

Merged
merged 1 commit into from
Jun 21, 2021
Merged

test: added check to test ZRS in dynamically provisioned test suite #875

merged 1 commit into from
Jun 21, 2021

Conversation

kassarl
Copy link
Contributor

@kassarl kassarl commented Jun 3, 2021

What type of PR is this?

/kind test

What this PR does / why we need it:
If the test is ran in a region that supports ZRS, it will set storage class parameters to use ZRS.
Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added kind/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 3, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @kassarl. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 3, 2021
andyzhangx
andyzhangx reviewed Jun 4, 2021
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 4, 2021
@andyzhangx
Copy link
Member

/retest

6 similar comments
@kassarl
Copy link
Contributor Author

kassarl commented Jun 8, 2021

/retest

@andyzhangx
Copy link
Member

/retest

@kassarl
Copy link
Contributor Author

kassarl commented Jun 10, 2021

/retest

@andyzhangx
Copy link
Member

/retest

@kassarl
Copy link
Contributor Author

kassarl commented Jun 15, 2021

/retest

@andyzhangx
Copy link
Member

/retest

@kassarl kassarl force-pushed the dynamically-provision-tests-include-zrs branch from 7aca80d to 4b5db59 Compare June 16, 2021 18:59
@kassarl
Copy link
Contributor Author

kassarl commented Jun 16, 2021

/retest

2 similar comments
@kassarl
Copy link
Contributor Author

kassarl commented Jun 17, 2021

/retest

@kassarl
Copy link
Contributor Author

kassarl commented Jun 17, 2021

/retest

@kassarl kassarl marked this pull request as draft June 17, 2021 23:17
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2021
@kassarl kassarl force-pushed the dynamically-provision-tests-include-zrs branch from 4b5db59 to b4a2d91 Compare June 18, 2021 00:15
@kassarl kassarl marked this pull request as ready for review June 18, 2021 00:15
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 18, 2021
@kassarl
test: added check for ZRS regions to test with ZRS
e7b7275 
test: fixed deployment and statefulset setup to take argument for storage class parameters
@kassarl kassarl force-pushed the dynamically-provision-tests-include-zrs branch from b4a2d91 to e7b7275 Compare June 18, 2021 00:39
@andyzhangx
Copy link
Member

/retest

andyzhangx
andyzhangx approved these changes Jun 18, 2021
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, kassarl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2021
@kassarl
Copy link
Contributor Author

kassarl commented Jun 21, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit 3b736f5 into kubernetes-sigs:master Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/test lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kassarl @k8s-ci-robot @andyzhangx