Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support fsGroupPolicy feature #871

Merged
merged 1 commit into from
May 28, 2021
Merged

feat: support fsGroupPolicy feature #871

merged 1 commit into from
May 28, 2021

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented May 28, 2021 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: support fsGroupPolicy feature

Which issue(s) this PR fixes:

Fixes #815

Requirements:

Special notes for your reviewer:

Release note:

feat: support fsGroupPolicy feature

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 28, 2021
@andyzhangx andyzhangx force-pushed the fsgrouppolicy branch 2 times, most recently from 8b769fc to 7d27f6d Compare May 28, 2021 10:07
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 28, 2021
@andyzhangx andyzhangx force-pushed the fsgrouppolicy branch 7 times, most recently from 50c0629 to 318c348 Compare May 28, 2021 12:19
@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
feat: support fsGroupPolicy feature
5e19bdf 
fix yaml lint

enable fsGroupPolicy

fix chart file

fix typo

update chart file

fix script

fix Makefile

fix Makefile

fix Makefile

fix Makefile
@andyzhangx andyzhangx changed the title [WIP]feat: support fsGroupPolicy feature feat: support fsGroupPolicy feature May 28, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 28, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 28, 2021 •
edited
Loading

@andyzhangx: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-azuredisk-csi-driver-e2e-windows-containerd 5e19bdf link /test pull-azuredisk-csi-driver-e2e-windows-containerd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andyzhangx andyzhangx merged commit 015cb6c into kubernetes-sigs:master May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

external e2e test: fsgroupchangepolicy tests failed
2 participants
@andyzhangx @k8s-ci-robot