Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor for OptimizeDiskPerformance code #865

Merged
merged 1 commit into from
May 28, 2021
Merged

chore: refactor for OptimizeDiskPerformance code #865

merged 1 commit into from
May 28, 2021

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented May 27, 2021 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
chore: refactor for OptimizeDiskPerformance code

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:
/hold

Release note:

none

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 27, 2021
@andyzhangx andyzhangx force-pushed the optimize-refactor branch from 9e927c8 to 155e046 Compare May 27, 2021 09:15
@andyzhangx
chore: refactor for OptimizeDiskPerformance code
845ef5f 
move dir

fix golint

fix echoToFile
@andyzhangx andyzhangx force-pushed the optimize-refactor branch from 155e046 to 845ef5f Compare May 27, 2021 13:02
@andyzhangx
Copy link
Member Author

interesting error:

create volume error: Retriable: false, RetryAfter: 0s, HTTPStatusCode: 400, RawError: Retriable: false, RetryAfter: 0s, HTTPStatusCode: 400, RawError: {
  "error": {
    "code": "BadRequest",
    "message": "MaxShares '2' for disk 'single-shared-disk' of size '256' GB is invalid. Please refer to https://docs.microsoft.com/azure/virtual-machines/windows/disks-shared-enable#disk-sizes"
  }

https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_azuredisk-csi-driver/865/pull-azuredisk-csi-driver-e2e-single-az/1397901026341687296/build-log.txt

/retest

@andyzhangx
Copy link
Member Author

/retest

1 similar comment
@andyzhangx
Copy link
Member Author

/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhisheksinghbaghel, andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andyzhangx andyzhangx removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2021
@andyzhangx andyzhangx merged commit 372d5b0 into kubernetes-sigs:master May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhisheksinghbaghel abhisheksinghbaghel abhisheksinghbaghel approved these changes

@feiskyer feiskyer Awaiting requested review from feiskyer

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyzhangx @k8s-ci-robot @abhisheksinghbaghel