-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup k8s external e2e tests #805
Conversation
Hi @boddumanohar. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/test pull-azuredisk-csi-driver-external-e2e-single-az |
ac4ef0a
to
4368a82
Compare
/test pull-azuredisk-csi-driver-external-e2e-single-az |
1 similar comment
/test pull-azuredisk-csi-driver-external-e2e-single-az |
ed75ed0
to
0aafc21
Compare
Makefile
Outdated
./deploy/install-driver.sh | ||
|
||
.PHONY: e2e-test | ||
e2e-test: setup-external-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should not depend on e2e-test: setup-external-e2e
bf2497f
to
e2fb42d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is charts/latest/azuredisk-csi-driver-v1.2.0.tgz
updated in this PR?
test/external-e2e/run.sh
Outdated
|
||
# download k8s external e2e binary for kubernetes v1.19 | ||
curl -sL https://storage.googleapis.com/kubernetes-release/release/v1.19.0/kubernetes-test-linux-amd64.tar.gz --output e2e-tests.tar.gz | ||
tar -xvf e2e-tests.tar.gz && rm e2e-tests.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated.
e2fb42d
to
e1a8745
Compare
sigh, quota exceeded, let's run those tests tomorrow. |
/retest |
test/external-e2e/run.sh
Outdated
tar -xvf e2e-tests.tar.gz && rm e2e-tests.tar.gz | ||
|
||
# install the azuredisk-csi-driver driver | ||
$PROJECT_ROOT/deploy/install-driver.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will install the master branch driver not current driver with code change, should depend on make e2e-bootstrap
to install driver.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated.
e1a8745
to
bb87668
Compare
@boddumanohar: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, boddumanohar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What type of PR is this?
Add k8s external e2e tests
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: