Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup k8s external e2e tests #805

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

boddumanohar
Copy link
Contributor

What type of PR is this?
Add k8s external e2e tests

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 25, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @boddumanohar. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 25, 2021
@andyzhangx
Copy link
Member

/ok-to-test
/test pull-azuredisk-csi-driver-external-e2e-single-az

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 26, 2021
@andyzhangx
Copy link
Member

/test pull-azuredisk-csi-driver-external-e2e-single-az

@boddumanohar boddumanohar force-pushed the external-e2e branch 3 times, most recently from ac4ef0a to 4368a82 Compare April 26, 2021 19:41
@andyzhangx
Copy link
Member

/test pull-azuredisk-csi-driver-external-e2e-single-az

1 similar comment
@andyzhangx
Copy link
Member

/test pull-azuredisk-csi-driver-external-e2e-single-az

@boddumanohar boddumanohar changed the title [WIP] setup k8s external e2e tests Setup k8s external e2e tests Apr 27, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 27, 2021
@boddumanohar boddumanohar force-pushed the external-e2e branch 2 times, most recently from ed75ed0 to 0aafc21 Compare April 27, 2021 09:53
Makefile Outdated
./deploy/install-driver.sh

.PHONY: e2e-test
e2e-test: setup-external-e2e
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not depend on e2e-test: setup-external-e2e

Makefile Show resolved Hide resolved
@boddumanohar boddumanohar force-pushed the external-e2e branch 2 times, most recently from bf2497f to e2fb42d Compare April 27, 2021 14:41
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is charts/latest/azuredisk-csi-driver-v1.2.0.tgz updated in this PR?


# download k8s external e2e binary for kubernetes v1.19
curl -sL https://storage.googleapis.com/kubernetes-release/release/v1.19.0/kubernetes-test-linux-amd64.tar.gz --output e2e-tests.tar.gz
tar -xvf e2e-tests.tar.gz && rm e2e-tests.tar.gz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

@andyzhangx
Copy link
Member

sigh, quota exceeded, let's run those tests tomorrow.

@andyzhangx
Copy link
Member

/retest

tar -xvf e2e-tests.tar.gz && rm e2e-tests.tar.gz

# install the azuredisk-csi-driver driver
$PROJECT_ROOT/deploy/install-driver.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will install the master branch driver not current driver with code change, should depend on make e2e-bootstrap to install driver.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

@k8s-ci-robot
Copy link
Contributor

@boddumanohar: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-azuredisk-csi-driver-e2e-windows-v2 bb87668 link /test pull-azuredisk-csi-driver-e2e-windows-v2

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, boddumanohar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2021
@andyzhangx
Copy link
Member

/retest

@andyzhangx andyzhangx merged commit 3e7d071 into kubernetes-sigs:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants