Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error when 2 pods mount same disk pvc on the same node #75

Merged

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Apr 14, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
When 2 pods mount same disk pvc on the same node, there will be error like error:

target "/var/lib/kubelet/plugins/kubernetes.io/csi/pv/pvc-de4f7c7d-5c76-11e9-9ea8-000d3a269e74/globalmount" is not a valid mount point

Which issue(s) this PR fixes:

Fixes #73

Special notes for your reviewer:

Release note:

fix error when 2 pods mount same disk pvc on the same node

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 14, 2019
@k8s-ci-robot k8s-ci-robot requested a review from feiskyer April 14, 2019 14:53
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 14, 2019
@andyzhangx andyzhangx changed the title fix multiple mounts on same disk pvc error fix error when 2 pods mount same disk pvc on the same node Apr 14, 2019
@andyzhangx andyzhangx force-pushed the fix-multi-mount-issue branch from 245c488 to 19430b3 Compare April 14, 2019 15:03
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 333fd8c into kubernetes-sigs:master Apr 15, 2019
sunpa93 pushed a commit to sunpa93/azuredisk-csi-driver that referenced this pull request Jun 14, 2021
…kubernetes-sigs#75)

* Extender logic update and perf test

* Array name fix.

* Fixing extender unittest.

* Undoing an unintended change in suite_test

* Finalizing extender logic.

* Commenting out the safecounter for roundRobin.

* Removing redundant name array.

* Reduced #of map lookups and fixed the case when cache entry is not in the map.

* Creating scheduler extender service account for v2 driver only.

* Fixed a typo.
sozercan pushed a commit to sozercan/azuredisk-csi-driver that referenced this pull request Aug 16, 2021
…ity-test

chore: enable sanity test in CI
dobsonj pushed a commit to dobsonj/azuredisk-csi-driver that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot mount disk due to findDiskByLun(0) failed within timeout
3 participants