Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windows image build error #609

Merged
merged 1 commit into from
Dec 8, 2020

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: windows image build error
This is a workaround fix, wait for buildkit fix on v0.8.0: moby/buildkit#1879

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

fix: windows image build error

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2020
@andyzhangx
Copy link
Member Author

/test pull-azuredisk-csi-driver-e2e-windows

@andyzhangx
Copy link
Member Author

/test pull-azuredisk-csi-driver-e2e-migration-windows

1 similar comment
@andyzhangx
Copy link
Member Author

/test pull-azuredisk-csi-driver-e2e-migration-windows

@andyzhangx andyzhangx merged commit 7894b94 into kubernetes-sigs:master Dec 8, 2020
sozercan pushed a commit to sozercan/azuredisk-csi-driver that referenced this pull request Aug 16, 2021
…eDataPlaneAPI

fix: honor useDataPlaneAPI in resize
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants