Fail when requested volume does not exist #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyzhangx
reviewed
Mar 2, 2019
|
|
||
| func getResourceGroupFromDiskURI(diskURI string) (string, error) { | ||
| fields := strings.Split(diskURI, "/") | ||
| if len(fields) != 9 || fields[3] != "resourceGroups" { |
There was a problem hiding this comment.
would you also copy the test code of TestGetResourceGroupFromDiskURI? thanks.
|
and this PR will also fail the CI test: |
|
I found why CI test failed, just pushed a new commit: 57fbcb6 |
|
@andyzhangx I have added the test. |
andyzhangx
approved these changes
Mar 2, 2019
sozercan
pushed a commit
to sozercan/azuredisk-csi-driver
that referenced
this pull request
Aug 16, 2021
use GetStorageAccesskey from azure lib
tsmetana
pushed a commit
to tsmetana/azuredisk-csi-driver
that referenced
this pull request
Nov 7, 2023
…gin-release-4.12 [release-4.12] OCPBUGS-20675: CVE-2023-44487: bump golang.org/x/net to v0.17.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix the following failure in sanity test
[Fail] Controller Service ValidateVolumeCapabilities [It] should fail when the requested volume does not exist /home/priyanshu/work/src/github.com/csi-driver/azuredisk-csi-driver/vendor/github.com/kubernetes-csi/csi-test/pkg/sanity/controller.go:705Which issue(s) this PR fixes:
Fixes #46
Special notes for your reviewer: