Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix in-tree resie e2e test failure #478

Merged
merged 2 commits into from
Aug 7, 2020

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Aug 7, 2020

What type of PR is this?
/kind test

What this PR does / why we need it:
test: fix in-tree resie e2e test failure


Dynamic Provisioning [single-az] should create a volume on demand and resize it [disk.csi.azure.com] [Windows] expand_less | 46s
-- | --
/home/prow/go/src/sigs.k8s.io/azuredisk-csi-driver/test/e2e/dynamic_provisioning_test.go:499 Test Panicked /usr/local/go/src/runtime/panic.go:212  Panic: runtime error: invalid memory address or nil pointer dereference  Full stack: sigs.k8s.io/azuredisk-csi-driver/test/e2e/testsuites.(*DynamicallyProvisionedResizeVolumeTest).Run(0xc000623328, 0x20fd0e0, 0xc000322c60, 0xc000704dc0) 	/home/prow/go/src/sigs.k8s.io/azuredisk-csi-driver/test/e2e/testsuites/dynamically_provisioned_resize_volume_tester.go:97 +0x903 sigs.k8s.io/azuredisk-csi-driver/test/e2e.(*dynamicProvisioningTestSuite).defineTests.func15() 	/home/prow/go/src/sigs.k8s.io/azuredisk-csi-driver/test/e2e/dynamic_provisioning_test.go:512 +0x1ed sigs.k8s.io/azuredisk-csi-driver/test/e2e.TestE2E(0xc000583200) 	/home/prow/go/src/sigs.k8s.io/azuredisk-csi-driver/test/e2e/suite_test.go:153 +0x1b6 testing.tRunner(0xc000583200, 0x1f2d650) 	/usr/local/go/src/testing/testing.go:1108 +0xef created by testing.(*T).Run 	/usr/local/go/src/testing/testing.go:1159 +0x386

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/93011/pull-kubernetes-e2e-azure-disk/1291576914372202496
related to PR: kubernetes/kubernetes#93011

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:
cc @Sakuralbj

Release note:

none

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2020
@andyzhangx
Copy link
Member Author

/test pull-azuredisk-csi-driver-e2e-migration

@andyzhangx
Copy link
Member Author

/test pull-azuredisk-csi-driver-e2e-multi-az

@andyzhangx andyzhangx force-pushed the resize-test-failure branch from e6b42e2 to 31f176b Compare August 7, 2020 07:12
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 7, 2020
@andyzhangx
Copy link
Member Author

/retest

fix resize failure

fix test failure
test: skip resize e2e test in migration test
@andyzhangx andyzhangx force-pushed the resize-test-failure branch from 81e783d to ed6b5fa Compare August 7, 2020 11:55
@k8s-ci-robot
Copy link
Contributor

@andyzhangx: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-azuredisk-csi-driver-e2e-multi-az ed6b5fa link /test pull-azuredisk-csi-driver-e2e-multi-az

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andyzhangx
Copy link
Member Author

/test pull-azuredisk-csi-driver-e2e-multi-az

@andyzhangx andyzhangx merged commit 64b52c8 into kubernetes-sigs:master Aug 7, 2020
sozercan pushed a commit to sozercan/azuredisk-csi-driver that referenced this pull request Aug 16, 2021
Fix the controllerexpand response to bytes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants