Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.30] fix: liveness probe failure when hostNetwork not enabled on linux node #2525

Merged
merged 1 commit into from
Sep 20, 2024
Merged

[release-1.30] fix: liveness probe failure when hostNetwork not enabled on linux node #2525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified charts/latest/azuredisk-csi-driver-v1.30.4.tgz
View file
Open in desktop
Binary file not shown.
16 changes: 15 additions & 1 deletion charts/latest/azuredisk-csi-driver/templates/csi-azuredisk-node.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,11 @@ spec:
args:
- --csi-address=/csi/csi.sock
- --probe-timeout=3s
{{- if eq .Values.node.hostNetwork true }}
- --http-endpoint=localhost:{{ .Values.node.livenessProbe.healthPort }}
{{- else }}
- --health-port={{ .Values.node.livenessProbe.healthPort }}
{{- end }}
- --v=2
resources: {{- toYaml .Values.linux.resources.livenessProbe | nindent 12 }}
securityContext:
Expand Down Expand Up @@ -140,12 +144,22 @@ spec:
- "--get-node-info-from-labels={{ .Values.linux.getNodeInfoFromLabels }}"
- "--get-nodeid-from-imds={{ .Values.node.getNodeIDFromIMDS }}"
- "--enable-otel-tracing={{ .Values.linux.otelTracing.enabled }}"
{{- if ne .Values.node.hostNetwork true }}
ports:
- containerPort: {{ .Values.node.livenessProbe.healthPort }}
name: healthz
protocol: TCP
{{- end }}
livenessProbe:
failureThreshold: 5
httpGet:
host: localhost
path: /healthz
{{- if eq .Values.node.hostNetwork true }}
host: localhost
port: {{ .Values.node.livenessProbe.healthPort }}
{{- else }}
port: healthz
{{- end }}
initialDelaySeconds: 30
timeoutSeconds: 10
periodSeconds: 30
Expand Down
4 changes: 4 additions & 0 deletions deploy/csi-azuredisk-node.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,10 @@ spec:
- "--enable-perf-optimization=true"
- "--allow-empty-cloud-config=true"
- "--get-node-info-from-labels=false"
ports:
- containerPort: 29603
name: healthz
protocol: TCP
livenessProbe:
failureThreshold: 5
httpGet:
Expand Down
Loading