-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add ReservedDataDiskSlotNum copy from DriverOptions to Driver struct #2384
fix: add ReservedDataDiskSlotNum copy from DriverOptions to Driver struct #2384
Conversation
Hi @ClementLachaussee. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/kind bug |
/ok-to-test |
can you squash all commits to one? |
…SlotNum Signed-off-by: ClementLachaussee <[email protected]>
c78b7d6
to
b74b5c0
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, ClementLachaussee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-1.30 |
/cherrypick release-1.29 |
/cherrypick release-1.28 |
@andyzhangx: new pull request created: #2385 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@andyzhangx: new pull request could not be created: failed to create pull request against kubernetes-sigs/azuredisk-csi-driver#release-1.29 from head k8s-infra-cherrypick-robot:cherry-pick-2384-to-release-1.29: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between kubernetes-sigs:release-1.29 and k8s-infra-cherrypick-robot:cherry-pick-2384-to-release-1.29"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@andyzhangx: new pull request created: #2386 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherrypick release-1.29 |
@andyzhangx: new pull request could not be created: failed to create pull request against kubernetes-sigs/azuredisk-csi-driver#release-1.29 from head k8s-infra-cherrypick-robot:cherry-pick-2384-to-release-1.29: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between kubernetes-sigs:release-1.29 and k8s-infra-cherrypick-robot:cherry-pick-2384-to-release-1.29"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Adds code that is required for the parameter ReservedDataDiskSlotNum to be used
Special notes for your reviewer:
https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/master/pkg/azuredisk/nodeserver.go#L395 was not modified even with VolumeAttachLimit < 0
It seems the option wasn't given to the Driver.ReservedDataDiskSlotNum which was = to 0
Release note: