feat: add startup taint removal feature #2309
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
feat: add startup taint removal feature
This PR is for solving the race condition between CSI driver initialization and disk volume scheduling, you could find details here: kubernetes/kubernetes#95911
user should add taint(
disk.csi.azure.com/agent-not-ready:NoExecute
) to node pool before CSI driver starts upWhich issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
There is a race condition between CSI driver initialization and kube-scheduler, we have added a taint removal feature (when CSI driver is started up) from aks 1.30, so cx could mitigate this issue, add taint
disk.csi.azure.com/agent-not-ready:NoExecute
in node pool creation and then after CSI driver is started, the taint would be removed by the CSI driver, that won’t be any race condition between CSI driver initialization and kube-scheduler any more.Use node taints in an Azure Kubernetes Service (AKS) cluster - Azure Kubernetes Service | Microsoft Learn
az aks nodepool add
--resource-group $RESOURCE_GROUP_NAME
--cluster-name $CLUSTER_NAME
--name $NODE_POOL_NAME
--node-count 1
--node-taints "disk.csi.azure.com/agent-not-ready:NoExecute"
--no-wait
Release note: